Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] Add pyyaml package
Date: Tue, 28 Jul 2015 00:11:13 +0200	[thread overview]
Message-ID: <20150728001113.2324729a@free-electrons.com> (raw)
In-Reply-To: <1437912738-24116-1-git-send-email-geoffrey.ragot@gmail.com>

Geoffrey,

The commit title should have been:

	python-pyyaml: new package

(just to follow the Buildroot conventions).

On Sun, 26 Jul 2015 14:12:17 +0200, Geoffrey Ragot wrote:

> diff --git a/package/python-pyyaml/Config.in b/package/python-pyyaml/Config.in
> new file mode 100644
> index 0000000..a63c445
> --- /dev/null
> +++ b/package/python-pyyaml/Config.in
> @@ -0,0 +1,8 @@
> +comment "python-pyyaml require libyaml"
> +	depends on !BR2_PACKAGE_LIBYAML

This comment is not needed...

> +
> +config BR2_PACKAGE_PYTHON_PYYAML
> +	bool "python-pyyaml"
> +	depends on BR2_PACKAGE_LIBYAML

... because 'select' should be used instead of 'depends on' for such
dependencies.

> +	help
> +	  The PyYAML package contains binding to the libyaml API.

We normally include the URL of the upstream project here.

> diff --git a/package/python-pyyaml/python-pyyaml.mk b/package/python-pyyaml/python-pyyaml.mk
> new file mode 100644
> index 0000000..ef10dac
> --- /dev/null
> +++ b/package/python-pyyaml/python-pyyaml.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# python-pyyaml
> +#
> +################################################################################
> +
> +PYTHON_PYYAML_VERSION = 3.11
> +PYTHON_PYYAML_SOURCE = PyYAML-$(PYTHON_PYYAML_VERSION).tar.gz
> +PYTHON_PYYAML_SITE = https://pypi.python.org/packages/source/P/PyYAML/
> +PYTHON_PYYAML_SETUP_TYPE = distutils
> +PYTHON_PYYAML_LICENSE = Python software foundation license v2
> +PYTHON_PYYAML_LICENSE_FILES = LICENSE
> +PYTHON_PYYAML_DEPENDENCIES = libyaml
> +
> +$(eval $(python-package))

The .mk file was OK, however, the .hash file was missing.

I've fixed those issues:

    [Thomas:
      - use 'select' rather than 'depends on' for the yaml library
        dependency
      - add hash file.
      - add upstream URL in Config.in help text
      - rework commit title.]

and applied.

Thanks for your contribution!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2015-07-27 22:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-26 12:12 [Buildroot] [PATCH 1/2] Add pyyaml package Geoffrey Ragot
2015-07-26 12:12 ` [Buildroot] [PATCH 2/2] Add pycli package Geoffrey Ragot
2015-07-28 22:04   ` Thomas Petazzoni
2015-07-27 22:11 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150728001113.2324729a@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox