From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] packages/btrfs-progs: fix build issues under musl
Date: Wed, 29 Jul 2015 22:47:26 +0200 [thread overview]
Message-ID: <20150729224726.71925205@free-electrons.com> (raw)
In-Reply-To: <1438195815-29424-1-git-send-email-brendanheading@gmail.com>
Dear Brendan Heading,
On Wed, 29 Jul 2015 19:50:15 +0100, Brendan Heading wrote:
> +diff --git a/kerncompat.h b/kerncompat.h
> +index 5d92856..7c627ba 100644
> +--- a/kerncompat.h
> ++++ b/kerncompat.h
> +@@ -33,7 +33,9 @@
> + #include <features.h>
> +
> + #ifndef __GLIBC__
> ++#ifndef BTRFS_DISABLE_BACKTRACE
> + #define BTRFS_DISABLE_BACKTRACE
> ++#endif
While this is a quick hack that works, I think it's really nothing more
than a hack. I've implemented what I believe is a better solution, can
you look at:
https://github.com/tpetazzoni/btrfs-progs/commits/configure-improvements
(last two commits)
Basically, this proposal uses configure.ac properly to detect backtrace
support.
Can you check if that continues to work fine with glibc and musl, and
if so, submit the patches upstream?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-07-29 20:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 18:50 [Buildroot] [PATCH 1/1] packages/btrfs-progs: fix build issues under musl Brendan Heading
2015-07-29 20:47 ` Thomas Petazzoni [this message]
2015-07-29 20:54 ` Brendan Heading
2015-07-30 14:16 ` Brendan Heading
2015-07-30 14:24 ` Thomas Petazzoni
2015-07-30 15:30 ` Brendan Heading
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150729224726.71925205@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox