From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Thu, 30 Jul 2015 17:03:52 +0200 Subject: [Buildroot] [PATCH 1/2] fs/iso9660: fix hybrid image support In-Reply-To: References: <1438267651-16818-1-git-send-email-nrubinstein@aldebaran.com> <20150730165052.1eea5a29@free-electrons.com> Message-ID: <20150730170352.0331b2c4@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear No? Rubinstein, On Thu, 30 Jul 2015 16:56:34 +0200, No? Rubinstein wrote: > On Thu, Jul 30, 2015 at 4:50 PM, Thomas Petazzoni > wrote: > > Can you resubmit with the && thing ? It is not needed: make will > > abort automatically if genisoimage fails. > > The issue is syntactic: ROOTFS_ISO9660_CMD is used in this line in common.mk: > > echo "$$(ROOTFS_$(2)_CMD)" >> $$(FAKEROOT_SCRIPT) > > Therefore it can not contain any newline. This would be fixed by using > the file function in GNU make > > but it would not work with GNU make 3.81. Hum then maybe in the end my _POST_GEN_HOOKS idea is better? Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com