Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/minidlna: More fixes to static compile
Date: Thu, 30 Jul 2015 23:33:48 +0200	[thread overview]
Message-ID: <20150730233348.2aad245e@free-electrons.com> (raw)
In-Reply-To: <1438203871-8548-1-git-send-email-bernd.kuhls@t-online.de>

Bernd,

On Wed, 29 Jul 2015 23:04:31 +0200, Bernd Kuhls wrote:

> diff --git a/package/minidlna/minidlna.mk b/package/minidlna/minidlna.mk
> index ab93484..2f75993 100644
> --- a/package/minidlna/minidlna.mk
> +++ b/package/minidlna/minidlna.mk
> @@ -17,9 +17,9 @@ MINIDLNA_DEPENDENCIES = \
>  ifeq ($(BR2_STATIC_LIBS),y)
>  # the configure script / Makefile forgets to link with some of the dependent
>  # libraries breaking static linking, so help it along
> -MINIDLNA_STATIC_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs libavcodec libexif libvorbis`
> +MINIDLNA_STATIC_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs libavcodec libexif vorbis sqlite3`
>  MINIDLNA_STATIC_LIBS += $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),-lintl)
> -MINIDLNA_CONF_ENV += LIBS="$(MINIDLNA_STATIC_LIBS)"
> +MINIDLNA_CONF_ENV += LIBS="$(MINIDLNA_STATIC_LIBS) -lm -lz"

Would it be possible to stop hacking this to death? What about instead
taking the saner approach of switching minidlna configure.ac to use
PKG_CHECK_MODULES(), which will remove a lot of crap from it, and make
it work properly for cross-compilation.

Some libraries, such as libid3tag, would also need to install a .pc
file, obviously.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-07-30 21:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-29 21:04 [Buildroot] [PATCH 1/1] package/minidlna: More fixes to static compile Bernd Kuhls
2015-07-30 19:58 ` Jörg Krause
2015-07-30 21:33 ` Thomas Petazzoni [this message]
2015-08-29 21:26 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150730233348.2aad245e@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox