Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] package/libv4l: needs argp-standalone with musl toolchains
Date: Mon, 3 Aug 2015 11:16:50 +0200	[thread overview]
Message-ID: <20150803111650.55613002@free-electrons.com> (raw)
In-Reply-To: <20150802152903.GF3647@free.fr>

Dear Yann E. MORIN,

On Sun, 2 Aug 2015 17:29:03 +0200, Yann E. MORIN wrote:

> Ditto, you also need to adjust the build dependencies in the .mk .
> 
> However, that one is doing things differently than the other two. It
> currently build-depends on argp-standalone and links with it as soon as
> the package is enabled.
> 
> I'm nt sure that's the best soltuion; it should only do that if built
> against uClibc or musl, like rng-tools and elfutils currently do.

Since argp-standalone/Config.in has:

	depends on !BR2_TOOLCHAIN_USES_GLIBC

then there is really no difference between:

ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
...
endif

and

ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC)$(BR2_TOOLCHAIN_USES_MUSL),y)
...
endif

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-08-03  9:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-01 16:55 [Buildroot] [PATCH 1/3] package/rng-tools: needs argp-standalone with musl toolchains Romain Naour
2015-08-01 16:55 ` [Buildroot] [PATCH 2/3] package/eflutils: " Romain Naour
2015-08-02 15:26   ` Yann E. MORIN
2015-08-03  9:15   ` Thomas Petazzoni
2015-08-01 16:55 ` [Buildroot] [PATCH 3/3] package/libv4l: " Romain Naour
2015-08-02 15:29   ` Yann E. MORIN
2015-08-03  9:16     ` Thomas Petazzoni [this message]
2015-08-03 16:27       ` Yann E. MORIN
2015-08-02 15:25 ` [Buildroot] [PATCH 1/3] package/rng-tools: " Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150803111650.55613002@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox