Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] dawgdic: new package
Date: Mon, 3 Aug 2015 23:14:40 +0300	[thread overview]
Message-ID: <20150803201440.GK3345@tarshish> (raw)
In-Reply-To: <1438593363-32653-1-git-send-email-yba@tkos.co.il>

Hi Yonatan,

On Mon, Aug 03, 2015 at 12:16:03PM +0300, Jonathan Ben-Avraham wrote:
> diff --git a/package/dawgdic/dawgdic.mk b/package/dawgdic/dawgdic.mk
> new file mode 100644
> index 0000000..f9b468e
> --- /dev/null
> +++ b/package/dawgdic/dawgdic.mk
> @@ -0,0 +1,17 @@
> +################################################################################
> +#
> +# dawgdic
> +#
> +################################################################################
> +
> +#DAWGDIC_SITE = http://dawgdic.googlecode.com/svn/trunk

Please remove.

> +DAWGDIC_SITE = https://github.com/stil/dawgdic.git
> +DAWGDIC_SITE_METHOD = git
> +DAWGDIC_VERSION = 16ac537ba9883ff01b63b6d1fdc3072150c68fee

Please use the github helper. See 
http://nightly.buildroot.org/manual.html#github-download-url.

> +DAWGDIC_LICENSE = GPLv3
> +DAWGDIC_LICENSE_FILES = COPYING
> +
> +DAWGDIC_AUTORECONF = YES

Why is that needed? Please explain in a comment.

> +DAWGDIC_INSTALL_STAGING = YES
> +
> +$(eval $(autotools-package))

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2015-08-03 20:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-03  9:16 [Buildroot] [PATCH v2 1/1] dawgdic: new package Jonathan Ben-Avraham
2015-08-03 20:14 ` Baruch Siach [this message]
2015-08-04  9:18 ` Thomas Petazzoni
2015-08-04  9:24   ` Jonathan Ben Avraham
2015-08-04  9:26     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150803201440.GK3345@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox