Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/9] docs/manual: document gcc version dependencies
Date: Tue, 4 Aug 2015 21:58:58 +0200	[thread overview]
Message-ID: <20150804195858.GW3647@free.fr> (raw)
In-Reply-To: <1438711241-31792-5-git-send-email-thomas.petazzoni@free-electrons.com>

Thomas, All,

On 2015-08-04 20:00 +0200, Thomas Petazzoni spake thusly:
> This commit updates the Buildroot manual to document how to detail the
> gcc version dependencies in Config.in comments of packages, like we do
> for kernel headers version.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

However, see a comment below...

> ---
>  docs/manual/adding-packages-directory.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt
> index 8f585d4..b66e447 100644
> --- a/docs/manual/adding-packages-directory.txt
> +++ b/docs/manual/adding-packages-directory.txt
> @@ -277,6 +277,12 @@ use in the comment.
>  ** Comment string: +headers >= X.Y+ and/or `headers <= X.Y` (replace
>     +X.Y+ with the proper version)
>  
> +* GCC version
> +** Dependency symbol: +BR2_TOOLCHAIN_GCC_AT_LEAST_X_Y+, (replace
> +   +X_Y+ with the proper version, see +toolchain/toolchain-common.in+)
> +** Comment string: +gcc >= X.Y+ and/or `gcc <= X.Y` (replace

One of the condition is between ++ and the other between ``. I konow you
just replicated what was done for the kernel headers, but wuld it not be
better to use only ++ (or only ``, I don't mind) but not both?

And fix the kernel one@the same time, maybe (or in a separate patch)?

Regards,
Yann E. MORIN.

> +   +X.Y+ with the proper version)
> +
>  * C library
>  ** Dependency symbol: +BR2_TOOLCHAIN_USES_GLIBC+,
>     +BR2_TOOLCHAIN_USES_MUSL+, +BR2_TOOLCHAIN_USES_UCLIBC+
> -- 
> 2.5.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-08-04 19:58 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-04 18:00 [Buildroot] [PATCH 0/9] Add gcc version dependency mechanism Thomas Petazzoni
2015-08-04 18:00 ` [Buildroot] [PATCH 1/9] toolchain: add common gcc version hidden config options Thomas Petazzoni
2015-08-04 19:12   ` Yann E. MORIN
2015-08-04 18:00 ` [Buildroot] [PATCH 2/9] gcc: select the appropriate BR2_TOOLCHAIN_GCC_AT_LEAST_* option Thomas Petazzoni
2015-08-04 19:14   ` Yann E. MORIN
2015-08-04 18:00 ` [Buildroot] [PATCH 3/9] toolchain-external: add support for gcc version dependency Thomas Petazzoni
2015-08-04 19:49   ` Yann E. MORIN
2015-08-05 10:14     ` Thomas Petazzoni
2015-08-08 12:23       ` Jörg Krause
2015-08-08 12:33         ` Thomas Petazzoni
     [not found]           ` <1485266737.8272514.1439293774884.JavaMail.zimbra@datacom.ind.br>
     [not found]             ` <979955045.8284402.1439295583830.JavaMail.zimbra@datacom.ind.br>
2015-08-12  8:30               ` Thomas Petazzoni
2015-08-04 18:00 ` [Buildroot] [PATCH 4/9] docs/manual: document gcc version dependencies Thomas Petazzoni
2015-08-04 19:58   ` Yann E. MORIN [this message]
2015-08-05  9:05     ` Thomas Petazzoni
2015-08-05 19:53       ` Yann E. MORIN
2015-08-04 18:00 ` [Buildroot] [PATCH 5/9] libsigrok: depends on gcc >= 4.7 Thomas Petazzoni
2015-08-04 20:08   ` Yann E. MORIN
2015-08-05  7:56     ` Thomas Petazzoni
2015-08-04 18:00 ` [Buildroot] [PATCH 6/9] upmpdcli: update to use the gcc version dependency mechanism Thomas Petazzoni
2015-08-04 20:11   ` Yann E. MORIN
2015-08-04 18:00 ` [Buildroot] [PATCH 7/9] zmqpp: " Thomas Petazzoni
2015-08-04 20:12   ` Yann E. MORIN
2015-08-05 10:15     ` Thomas Petazzoni
2015-08-04 18:00 ` [Buildroot] [PATCH 8/9] libupnpp: " Thomas Petazzoni
2015-08-04 20:21   ` Yann E. MORIN
2015-08-04 18:00 ` [Buildroot] [PATCH 9/9] mpd: " Thomas Petazzoni
2015-08-04 20:22   ` Yann E. MORIN
2015-08-05 10:13 ` [Buildroot] [PATCH 0/9] Add " Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150804195858.GW3647@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox