From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] rapidxml: new package
Date: Tue, 4 Aug 2015 23:40:11 +0300 [thread overview]
Message-ID: <20150804204011.GM3345@tarshish> (raw)
In-Reply-To: <alpine.DEB.2.02.1508041932350.7707@orcam81.orcam.lan>
Hi Yonatan,
On Tue, Aug 04, 2015 at 07:37:14PM +0300, Jonathan Ben Avraham wrote:
> >On Mon, Aug 03, 2015 at 09:04:14PM +0300, Jonathan Ben-Avraham wrote:
> >>+RAPIDXML_INSTALL_TARGET = NO
> >
> >This needs an explanation comment. Is this a header only package?
> >
> >>+RAPIDXML_INSTALL_STAGING = YES
[snip]
> Regarding "This needs an explanation comment. Is this a header only
> package?", you can see from RAPIDXML_INSTALL_TARGET = NO and
> RAPIDXML_INSTALL_STAGING = YES that the answer must be "yes". I did not see
> a need to add a comment since the precedent package "rapidjson", also has no
> comment.
Set precedents are not always a good guide. That's the case here, IMO.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
prev parent reply other threads:[~2015-08-04 20:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 18:04 [Buildroot] [PATCH 1/1] rapidxml: new package Jonathan Ben-Avraham
2015-08-03 19:57 ` Baruch Siach
2015-08-04 16:37 ` Jonathan Ben Avraham
2015-08-04 20:40 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804204011.GM3345@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox