From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3 v2] package/xserver: commonalise dependency on libdrm
Date: Wed, 5 Aug 2015 22:11:05 +0200 [thread overview]
Message-ID: <20150805201104.GE3647@free.fr> (raw)
In-Reply-To: <20150731165905.GA3751@free.fr>
Thomas, All,
On 2015-07-31 18:59 +0200, Yann E. MORIN spake thusly:
> On 2015-07-31 07:57 +0200, Thomas Petazzoni spake thusly:
> > On Fri, 31 Jul 2015 00:59:05 +0200, Yann E. MORIN wrote:
> > > ifeq ($(BR2_PACKAGE_MESA3D_DRI_DRIVER),y)
> > > -XSERVER_XORG_SERVER_CONF_OPTS += --enable-dri --enable-libdrm --enable-glx
> > > -XSERVER_XORG_SERVER_DEPENDENCIES += libdrm mesa3d xproto_xf86driproto
> > > +XSERVER_XORG_SERVER_CONF_OPTS += --enable-dri --enable-glx
> > > +XSERVER_XORG_SERVER_DEPENDENCIES += mesa3d xproto_xf86driproto
> > > +XSERVER_XORG_SERVER_NEEDS_LIBDRM = y
> >
> > Hum, didn't we say that this should be a hidden Config.in boolean?
>
> Yes, you suggested so; I said yes; I tried; I said no... ;-)
> http://lists.busybox.net/pipermail/buildroot/2015-July/135100.html
>
> Basically, all the conditional code is in the .mk , and there's almost
> no conditional in the Config.in.
>
> So, I'd like not to duplicate the decision making in Config.in and keep
> all in a single place, the .mk .
>
> That's why I did not move that to a blind kconfig option.
Did you make up your mind about this?
Now that we've switched to a mdular server by default, this series is
now fixing actual autobuild errors...
If you really prefer that we duplicate all the logic in Config.in , I'll
do it.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-08-05 20:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 22:59 [Buildroot] [PATCH 0/3 v2] xorg: fix dependencies, add fbturbo driver (branch yem/xorg) Yann E. MORIN
2015-07-30 22:59 ` [Buildroot] [PATCH 1/3 v2] package/xserver: commonalise dependency on libdrm Yann E. MORIN
2015-07-31 5:57 ` Thomas Petazzoni
2015-07-31 16:59 ` Yann E. MORIN
2015-08-05 20:11 ` Yann E. MORIN [this message]
2015-08-08 12:04 ` Bernd Kuhls
2015-07-30 22:59 ` [Buildroot] [PATCH 2/3 v2] package/xserver_xorg-server: dri2 needs libdrm Yann E. MORIN
2015-07-30 22:59 ` [Buildroot] [PATCH 3/3 v2] xdriver_xf86-video-fbturbo: new package Yann E. MORIN
2015-10-03 17:37 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805201104.GE3647@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox