Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] package/eudev: fix build with musl + libselinux
Date: Thu, 6 Aug 2015 09:07:10 +0200	[thread overview]
Message-ID: <20150806090710.7f68171e@free-electrons.com> (raw)
In-Reply-To: <1438349093-17604-1-git-send-email-romain.naour@openwide.fr>

Dear Romain Naour,

On Fri, 31 Jul 2015 15:24:53 +0200, Romain Naour wrote:
> Add a patch to disable mallinfo statistics with musl toolchains
> which doesn't have struct mallinfo.
> 
> Fixes:
> selinux-util.c: In function ?mac_selinux_init?:
> selinux-util.c:70:25: error: storage size of ?before_mallinfo? isn?t known
>          struct mallinfo before_mallinfo, after_mallinfo;
> 
> Add a second patch for strndupa() which is a GNU extension.
> 
> Fixes:
> ./.libs/libudev-core.a(selinux-util.o): In function `mac_selinux_bind':
> selinux-util.c:(.text+0xd94): undefined reference to `strndupa'
> collect2: error: ld returned 1 exit status
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> Cc: Clayton Shotwell <clshotwe@rockwellcollins.com>
> ---
> v3: Don't enclose the timestamp stuff inside HAVE_MALLINFO (ThomasP)
> v2: new patch
> ---
>  .../eudev/0002-build-sys-check-for-mallinfo.patch  | 93 ++++++++++++++++++++++
>  .../eudev/0003-build-sys-check-for-strndupa.patch  | 69 ++++++++++++++++
>  package/eudev/eudev.mk                             |  5 ++
>  3 files changed, 167 insertions(+)
>  create mode 100644 package/eudev/0002-build-sys-check-for-mallinfo.patch
>  create mode 100644 package/eudev/0003-build-sys-check-for-strndupa.patch

I've applied the patch, with the hope that the patches will be merged
upstream. Supporting musl+selinux is a fairly odd setup, so carrying
around forever patches for this specific setup would be a bit annoying.

Can you make sure to keep pushing the patches upstream?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-08-06  7:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-31 13:24 [Buildroot] [PATCH v3] package/eudev: fix build with musl + libselinux Romain Naour
2015-08-06  7:07 ` Thomas Petazzoni [this message]
2015-08-06  8:37   ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150806090710.7f68171e@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox