Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] .hash files for all packages?
Date: Tue, 11 Aug 2015 10:55:45 +0200	[thread overview]
Message-ID: <20150811085545.GA3627@free.fr> (raw)
In-Reply-To: <20150811101333.2fd48c22@free-electrons.com>

Thomas, All,

On 2015-08-11 10:13 +0200, Thomas Petazzoni spake thusly:
> On Mon, 10 Aug 2015 22:47:25 +0200, Yann E. MORIN wrote:
> > I think the overall goal is to have .hash files for all packages. Having
> > a .hash files for all packages would allow us to make hashes truly
> > mandatory, and make a missing .hash file an error, rather than the
> > warning it is today.
> > 
> > Which in turn would ensure we have hashes for all packages for which it
> > makes sense.
> > 
> > Of course, that would mean adding a 'none' hash for those packages for
> > which we can't have  ahash (like the github helper, or any git/svn/... 
> > checkouts.
> > 
> > So, what J?rg did was in my opinion correct, even if we did not
> > explicitly document that! ;-)
> 
> Ok. I'm a bit worried about having 220 useless hash files,

The problem we have when there is no .hash file, is that we can't
differentiate those two cases;
  - there is no hash for this package, because it does not make sense
    (github helper, git/svn/foo checkout...)
  - we forgot to add a hash for that package.

I can understand that having lots of similarly looking files that jsut
say "don't do hash checks" might seem a bit worrying at first.

But I do think we really do need a way to explicitly say so.

Adding Gustavo in Cc because we already talked about that with him, and
last we discussed this, I think he agreed (well, I have IRC logs to back
that claim up! ;-] )

> so I'd like
> to hear the opinion of others on that. And once we made our decision,
> document it more clearly.

Yes, it should be throughly documented.

But note: this will have an impact on BR2_EXTERNAL trees; they will also
have to provide .hash files for their packages.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2015-08-11  8:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-04  9:57 [Buildroot] [PATCH 1/2] package/poco: bump to version 1.6.1 Jörg Krause
2015-08-04  9:57 ` [Buildroot] [PATCH 2/2] package/poco: disable for static build Jörg Krause
2015-08-06  6:56   ` Thomas Petazzoni
2015-08-10 14:22 ` [Buildroot] [PATCH 1/2] package/poco: bump to version 1.6.1 Thomas Petazzoni
2015-08-10 14:34   ` Jörg Krause
2015-08-10 18:54     ` Thomas Petazzoni
2015-08-10 20:47       ` Yann E. MORIN
2015-08-11  8:13         ` [Buildroot] .hash files for all packages? Thomas Petazzoni
2015-08-11  8:55           ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150811085545.GA3627@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox