Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] [autobuild] package/lightning: fix build for static-only
Date: Thu, 13 Aug 2015 22:55:55 +0300	[thread overview]
Message-ID: <20150813195555.GA25261@tarshish> (raw)
In-Reply-To: <1439477908-24088-1-git-send-email-yann.morin.1998@free.fr>

Hi Yann,

On Thu, Aug 13, 2015 at 04:58:28PM +0200, Yann E. MORIN wrote:
> Fixes:
>     http://autobuild.buildroot.org/results/019/019b6f2ac034766a4266e20e5dcc229bec4a7222/
>     http://autobuild.buildroot.org/results/55d/55d30db7212863d9f898bb929f0c75d529036bad/
>     http://autobuild.buildroot.org/results/459/459ab12bc3eeb493f39efa2450bc829a351ee3a3/
>     ...
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Paul Cercueil <paul@crapouillou.net>
> ---
>  package/lightning/0003-no-check-no-doc.patch | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 package/lightning/0003-no-check-no-doc.patch
> 
> diff --git a/package/lightning/0003-no-check-no-doc.patch b/package/lightning/0003-no-check-no-doc.patch
> new file mode 100644
> index 0000000..91a1684
> --- /dev/null
> +++ b/package/lightning/0003-no-check-no-doc.patch
> @@ -0,0 +1,21 @@
> +Makefile: do not build checks or docs
> +
> +checks require a toolchain with shared libs, so they FTBFS when the
> +build is static-only.
> +
> +Docs we don't care about in Buildroot.

In http://patchwork.ozlabs.org/patch/505871/ I opted for disabling static 
build support entirely. I see the value in preserving static build ability, 
but this patch is not upstreamable in its current form. I'm fine both ways.

> +
> +Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> +
> +diff -durN lightning-2.0.5.orig/Makefile.am lightning-2.0.5/Makefile.am
> +--- lightning-2.0.5.orig/Makefile.am	2013-09-24 05:37:46.000000000 +0200
> ++++ lightning-2.0.5/Makefile.am	2015-08-13 16:27:20.626730913 +0200
> +@@ -17,8 +17,6 @@
> + ACLOCAL_AMFLAGS = -I m4
> + 
> + SUBDIRS =		\
> +-	check		\
> +-	doc		\
> + 	include		\
> + 	lib

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2015-08-13 19:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-13 14:58 [Buildroot] [PATCH] [autobuild] package/lightning: fix build for static-only Yann E. MORIN
2015-08-13 19:55 ` Baruch Siach [this message]
2015-08-18  9:20 ` Thomas Petazzoni
2015-08-18  9:36   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150813195555.GA25261@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox