Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] [autobuild] package/oprofile: fix static linking
Date: Sun, 16 Aug 2015 23:48:43 +0200	[thread overview]
Message-ID: <20150816214843.GH3650@free.fr> (raw)
In-Reply-To: <20150816180245.GE2765@tarshish>

Baruch, All,

On 2015-08-16 21:02 +0300, Baruch Siach spake thusly:
> On Sun, Aug 16, 2015 at 04:53:27PM +0200, Yann E. MORIN wrote:
> > +# popt links with -lintl and specifies it in its popt.pc, and has done
> > +# so for the past 6+ years, but oprofile does not use pkconfig to find
> > +# popt, so we need to tell it to link with -lintl for a static build.
> > +ifeq ($(BR2_PACKAGE_GETTEXT)$(BR2_STATIC_LIBS),yy)
> > +OPROFILE_CONF_ENV += LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs popt`"
> > +endif
> 
> Well, the whole point of running $(PKG_CONFIG_HOST_BINARY) is that its output 
> matches the actual build dependencies. So the 'ifeq' should not be needed, 
> just like logrotate.

So true. Thanks for the reviews! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2015-08-16 21:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-16 14:53 [Buildroot] [PATCHv2] [autobuild] package/oprofile: fix static linking Yann E. MORIN
2015-08-16 18:02 ` Baruch Siach
2015-08-16 21:48   ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150816214843.GH3650@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox