From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package/canfestival: fix musl compilation
Date: Tue, 18 Aug 2015 08:53:04 +0300 [thread overview]
Message-ID: <20150818055304.GU2765@tarshish> (raw)
In-Reply-To: <1439848293-26836-1-git-send-email-brendanheading@gmail.com>
Hi Brendan,
On Mon, Aug 17, 2015 at 10:51:33PM +0100, Brendan Heading wrote:
> Fixes: http://autobuild.buildroot.net/results/75a/75aa6e7e4f3dcd74e4b65496060328ec7bd0e747/
>
> ANSI signal handlers take an int parameter, not sigval_t.
>
> Upstream-status: pending
>
> ---
This cuts off your sign-off below. Patch version info should go ...
> v1 -> v2 - added missing link to autobuild failure in commit comment
> ---
>
> Signed-off-by: Brendan Heading <brendanheading@gmail.com>
> ---
... here.
> .../canfestival/0003-fix-musl-compilation.patch | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
> create mode 100644 package/canfestival/0003-fix-musl-compilation.patch
>
> diff --git a/package/canfestival/0003-fix-musl-compilation.patch b/package/canfestival/0003-fix-musl-compilation.patch
> new file mode 100644
> index 0000000..dfe16a7
> --- /dev/null
> +++ b/package/canfestival/0003-fix-musl-compilation.patch
> @@ -0,0 +1,22 @@
> +# HG changeset patch
> +# User Brendan Heading <brendanheading@gmail.com>
> +# Date 1439845818 -3600
> +# Mon Aug 17 22:10:18 2015 +0100
> +# Node ID 7d62beec4f813074ba250231762f4b84395cc354
> +# Parent 8bfe0ac00cdb4d473664fcbf1228a0f6a42eee15
> +Fix MUSL compilation issue
> +
> +signal handler parameter fixed to be int instead of sigval_t.
Missing sign-off.
> +
> +diff -r 8bfe0ac00cdb -r 7d62beec4f81 drivers/timers_unix/timers_unix.c
> +--- a/drivers/timers_unix/timers_unix.c Mon Aug 03 18:01:58 2015 +0200
> ++++ b/drivers/timers_unix/timers_unix.c Mon Aug 17 22:10:18 2015 +0100
> +@@ -33,7 +33,7 @@
> + }
> + }
> +
> +-void timer_notify(sigval_t val)
> ++void timer_notify(int val)
> + {
> + if(gettimeofday(&last_sig,NULL)) {
> + perror("gettimeofday()");
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
prev parent reply other threads:[~2015-08-18 5:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 21:51 [Buildroot] [PATCH v2 1/1] package/canfestival: fix musl compilation Brendan Heading
2015-08-18 5:37 ` Jörg Krause
2015-08-18 14:28 ` Brendan Heading
2015-08-18 5:53 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150818055304.GU2765@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox