Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] [autobuild] package/systat: fix linking with -lintl
Date: Tue, 18 Aug 2015 11:39:14 +0200	[thread overview]
Message-ID: <20150818113914.6aec82ea@free-electrons.com> (raw)
In-Reply-To: <1439473701-21909-1-git-send-email-yann.morin.1998@free.fr>

Dear Yann E. MORIN,

On Thu, 13 Aug 2015 15:48:21 +0200, Yann E. MORIN wrote:
> When lining, libraries should be listed in the reverse-dependency order,

lining -> linking

> that is the library/ies with no dependency last, preceded by libraries
> that depend on them.
> 
> And most importantly, libraries should be listed *after* the local
> objects, .o files.
> 
> Currently, sysstat uses CFLAGS to shoehorn the -lintl linker flags,
> which is incorrect, as the CFLAGS are passed before the object files.
> 
> However, sysstat has a LFLAGS variable that, presumably, is to be used
> to pass linker flags. This is where we want to shoehorn -lintl.
> 
> Fixes:
>     http://autobuild.buildroot.org/results/8cc/8cc547074de23b9482ad110234ef7458a44e174a/
>     http://autobuild.buildroot.org/results/360/360f7b8252dc9f6bb47841b1d7207a121f90048c/
>     http://autobuild.buildroot.org/results/04c/04cfc76a09e089985549a4320f34f6669d21cab5/
>     http://autobuild.buildroot.org/results/818/818c08decf4a6190a9ed39915eae4cd3d2779880/
>     ...
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>  package/sysstat/sysstat.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2015-08-18  9:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-13 13:48 [Buildroot] [PATCH] [autobuild] package/systat: fix linking with -lintl Yann E. MORIN
2015-08-18  9:39 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150818113914.6aec82ea@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox