From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain/external: ensure gcc version is known
Date: Tue, 18 Aug 2015 13:05:38 +0200 [thread overview]
Message-ID: <20150818130538.55e63112@free-electrons.com> (raw)
In-Reply-To: <1439468003-27047-1-git-send-email-yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Thu, 13 Aug 2015 14:13:23 +0200, Yann E. MORIN wrote:
> Currently, when a preconfigured prebuilt toolchain forgets to specify
> its gcc version, the error message is a bit misleading, like:
>
> Incorrect selection of gcc version: expected .x, got 4.9.2
>
> Add a an explicit check for the gcc version being set, that reports a
> better error message.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> ---
> Note: we do not need the same check for kernel headers, because for
> those, we really ensure a version is set, namely 2.6.x, whereas we do
> not set a default 'REALLY_OLD' gcc version (and we can't really do so).
> ---
> toolchain/helpers.mk | 4 ++++
> 1 file changed, 4 insertions(+)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-08-18 11:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 12:13 [Buildroot] [PATCH] toolchain/external: ensure gcc version is known Yann E. MORIN
2015-08-18 11:05 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150818130538.55e63112@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox