From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Tue, 18 Aug 2015 14:13:55 +0200 Subject: [Buildroot] [PATCH v2] Add patch to fix linking issue In-Reply-To: <1439239075-14631-1-git-send-email-simon.marchi@polymtl.ca> References: <1439239075-14631-1-git-send-email-simon.marchi@polymtl.ca> Message-ID: <20150818141355.7b89a502@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Simon Marchi, On Mon, 10 Aug 2015 16:37:55 -0400, Simon Marchi wrote: > This patch fixes this autobuild failure: > > http://autobuild.buildroot.net/results/e14/e14e1700d4fe359c56be57587bdb509e002e5753/build-end.log > > The problem is caused by the -fvisibility-inlines-hidden switch. > Removing the switch is probably the least intrusive way we can make the > problem go away. The first solution that was considered was to move the > definition of the offending method to the .cpp file. However, with > other combinations of compilers and platforms, I suppose it could happen > with other methods as well. Removing the switch ensures we catch them > all. > > Built-tested with the config from the build bot, as well as with all OLA > options/plugins enabled. > > Signed-off-by: Simon Marchi The title of the patch should be: ola: add patch to fix linking issue > diff --git a/package/ola/0001-Remove-fvisibiliy-inlines-hidden.patch b/package/ola/0001-Remove-fvisibiliy-inlines-hidden.patch > new file mode 100644 > index 0000000..ac087f4 > --- /dev/null > +++ b/package/ola/0001-Remove-fvisibiliy-inlines-hidden.patch > @@ -0,0 +1,25 @@ > +From c160119ff3ff595862e7ba2a7b8bcb3302f13f02 Mon Sep 17 00:00:00 2001 > +From: Simon Marchi > +Date: Mon, 10 Aug 2015 15:01:42 -0400 > +Subject: [PATCH] Remove -fvisibiliy-inlines-hidden > + Missing Signed-off-by here. Can you respin after fixing those issues? Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com