From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] mtd: drop unconditional non LFS build
Date: Tue, 18 Aug 2015 22:44:39 +0200 [thread overview]
Message-ID: <20150818224439.21855624@free-electrons.com> (raw)
In-Reply-To: <69313616e067d45fde821f7f7d6ee388f323319d.1439267733.git.baruch@tkos.co.il>
Dear Baruch Siach,
On Tue, 11 Aug 2015 07:35:33 +0300, Baruch Siach wrote:
> Buildroot removed non LFS support in the 2015.05 release. We now pass
> -D_FILE_OFFSET_BITS=64 unconditionally, so the mtd WITHOUT_LARGEFILE make
> variable has no effect.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/mtd/mtd.mk | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/package/mtd/mtd.mk b/package/mtd/mtd.mk
> index edf6e083ed60..5f14f1677645 100644
> --- a/package/mtd/mtd.mk
> +++ b/package/mtd/mtd.mk
> @@ -24,15 +24,13 @@ ifeq ($(BR2_PACKAGE_BUSYBOX),y)
> MTD_DEPENDENCIES += busybox
> endif
>
> -MTD_MAKE_OPTS = WITHOUT_LARGEFILE=1
> -
> # If extended attributes are required, the acl package must
> # also be enabled which will also include the attr package.
> ifeq ($(BR2_PACKAGE_ACL),y)
> MTD_DEPENDENCIES += acl
> -MTD_MAKE_OPTS += WITHOUT_XATTR=0
> +MTD_MAKE_OPTS = WITHOUT_XATTR=0
> else
> -MTD_MAKE_OPTS += WITHOUT_XATTR=1
> +MTD_MAKE_OPTS = WITHOUT_XATTR=1
I believe using += is still better, as it will avoid potential mistakes
in the future. I've reverted to use += instead, and applied your patch
to next. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-08-18 20:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 4:35 [Buildroot] [PATCH] mtd: drop unconditional non LFS build Baruch Siach
2015-08-18 20:44 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150818224439.21855624@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox