Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/downlaod: fix the Hg backend for tags
Date: Sun, 23 Aug 2015 11:05:24 +0200	[thread overview]
Message-ID: <20150823090524.GA3729@free.fr> (raw)
In-Reply-To: <55D8FC04.8040600@mind.be>

Arnout, All,

On 2015-08-23 00:47 +0200, Arnout Vandecappelle spake thusly:
> On 08/18/2015 11:35 PM, Yann E. MORIN wrote:
> > When the version of a package is a Mercurial tag, the download fails,
> > with:
> >     abort: unknown revision 'X.Y.Z'!
> > 
> > This is because, in Mercurial, tags are commits like the others, and
> > when we clone, we actively request a tag. But then, the server
> > "dereferences" that tag and sends us the revision pointed to by that
> > tag. Of course, since the tag is a commit after the revision we got,
> > we do not have the revision adding the tag.
> > 
> > So, we just have to download the full repository to be sure we have
> > the tags in our local clone.
> > 
> > Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > ---
> >  support/download/hg | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/support/download/hg b/support/download/hg
> > index d6654a1..ac1e9b9 100755
> > --- a/support/download/hg
> > +++ b/support/download/hg
> > @@ -25,7 +25,7 @@ repo="${2}"
> >  cset="${3}"
> >  basename="${4}"
> >  
> > -${HG} clone ${verbose} --noupdate --rev "${cset}" "${repo}" "${basename}"
> > +${HG} clone ${verbose} --noupdate "${repo}" "${basename}"
> >  
> >  ${HG} archive ${verbose} --repository "${basename}" --type tgz \
> >                --prefix "${basename}" --rev "${cset}" \
> 
>  Wouldn't it be better to stick to the original way of cloning, and instead
> specify the equivalent of HEAD as --rev here? I think that would even be the
> default, no?

That would be 'tip' in Mercurial parlance.

And yes, worth a try...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-08-23  9:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-18 21:35 [Buildroot] [PATCH] support/downlaod: fix the Hg backend for tags Yann E. MORIN
2015-08-22 22:47 ` Arnout Vandecappelle
2015-08-23  9:05   ` Yann E. MORIN [this message]
2015-08-23  9:29   ` Yann E. MORIN
2015-08-29  9:45 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150823090524.GA3729@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox