Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Add missing config to RPM target package
Date: Sun, 23 Aug 2015 20:06:04 +0200	[thread overview]
Message-ID: <20150823200604.0c1e00cb@free-electrons.com> (raw)
In-Reply-To: <55D70AF3.3050604@gmx.de>

Andreas,

On Fri, 21 Aug 2015 13:26:43 +0200, universe II wrote:

> building the RPM package for my remote target I found a misconfiguration 
> of the .mk file.
> If the regular expression package pcre is enabled in buildroot, rpm will 
> use it. If not, nothing will be used and regular expression are not 
> available, making rpm unusable. But rpm has the ability to use an 
> internal pcre implementation if the external lib is not available. This 
> needs to be correctly activated before building and then rpm works fine 
> on the target. See the attached patch for more details.

We generally don't want to use the internal copy of libraries, and
prefer to use the system-provided library when possible, which is what
is done here.

So there are really two cases:

 1 Either the regexp support in RPM is absolutely mandatory for RPM to
   be useful. If this is the case, then just make the pcre dependency a
   mandatory one, and always pass --with-pcre=external.

 2 Or the regexp support in RPM is really optional, and useful only in
   certain situations. If this is the case, then what is done today is
   correct, and you should simply enable the pcre library.

Consequently, I've marked your patch as Rejected in our patch tracking
system. Do not hesitate to follow up with a different patch if we are
in case (1) above.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-08-23 18:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-21 11:26 [Buildroot] Add missing config to RPM target package universe II
2015-08-21 13:41 ` Vicente Olivert Riera
2015-08-24 16:25   ` universe II
2015-08-25  9:38     ` Vicente Olivert Riera
2015-08-25 19:14       ` Andreas Ehmanns
2015-08-23 18:06 ` Thomas Petazzoni [this message]
2015-08-25 19:28   ` Andreas Ehmanns
2015-08-31 14:32     ` Thomas Petazzoni
     [not found]       ` <55E89D2B.4090804@gmx.de>
2015-12-04  7:30         ` Andreas Ehmanns
2015-12-04  8:13           ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150823200604.0c1e00cb@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox