Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/canfestival: don't build in parallel
Date: Tue, 25 Aug 2015 15:12:31 +0200	[thread overview]
Message-ID: <20150825151231.43abeaa8@free-electrons.com> (raw)
In-Reply-To: <20150825115550.GA3794@free.fr>

Yann,

On Tue, 25 Aug 2015 13:55:50 +0200, Yann E. MORIN wrote:

> > Do you actually understand why make is displaying those warning
> > messages in the first place?
> 
> Yes, and it's a bit tricky.
> 
> canfestival indeed uses $(MAKE) everywhere. However, it is using it in a
> variable, like so:
> 
>     define build_cmds
>         $(MAKE) foo
>         $(MAKE) bar
>     endef
> 
>     all:
>         $(build_cmds)
>
> Since $(MAKE) is not directly in the rule body, it looses its magic
> behaviour. This is explicited said so in the make manual:
> 
>     This special feature is only enabled if the MAKE variable appears
>     directly in the recipe: it does not apply if the MAKE variable is
>     referenced through expansion of another variable.
> 
> Ergo.

I have to say I really like working on Buildroot with smart people,
because I learn things every day. Thanks for pointing me to this part
of the documentation I overlooked! I will apply your patch.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-08-25 13:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-22 21:34 [Buildroot] [PATCH] package/canfestival: don't build in parallel Yann E. MORIN
2015-08-25 10:17 ` Thomas Petazzoni
2015-08-25 11:55   ` Yann E. MORIN
2015-08-25 13:12     ` Thomas Petazzoni [this message]
2015-08-25 18:53 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150825151231.43abeaa8@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox