Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] [v3] libgudev: New package
Date: Tue, 25 Aug 2015 20:48:33 +0200	[thread overview]
Message-ID: <20150825204833.57f5a846@free-electrons.com> (raw)
In-Reply-To: <1440431056-25983-1-git-send-email-nroach44@gmail.com>

Nathaniel,

On Mon, 24 Aug 2015 23:44:14 +0800, Nathaniel Roach wrote:
> As libgudev recently was split from the main systemd/udev source,
> 	this library is now required to build certain packages.
> 
> This library is only relevant to systemd, as the code it contains
> 	is still contained in eudev.
> 
> Add the package and tweak systemd's Config.in message accordingly.
> 
> ---
> Changes v2 -> v3
> (Changes as suggested by Yann E. MORIN)
>  - Separate libgudev and network-manager portions into
> 	discrete patches, and a new patch for libmbim

Applied after doing a few changes:

    [Thomas:
     - don't show the dependency comment when systemd is not available,
       since libgudev is anyway useless when you're not using systemd.
     - fix the license, it's LGPLv2.1+ and not GPLv2+
     - remove useless empty lines in the .mk file.]

In addition to this, two comments:

 * Your SoB line should be before the first "---". Otherwise, it gets
   removed by git when applying the patch (anything after the first
   "---" gets ignored by git in terms of commit log)

 * Don't indent the second line of paragraphs with a tab, we don't do
   this in general for Buildroot commit logs.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2015-08-25 18:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-24 15:44 [Buildroot] [PATCH 1/3] [v3] libgudev: New package Nathaniel Roach
2015-08-24 15:44 ` [Buildroot] [PATCH 2/3] package/network-manager: Now needs libgudev under systemd Nathaniel Roach
2015-08-25 18:49   ` Thomas Petazzoni
2015-08-24 15:44 ` [Buildroot] [PATCH 3/3] package/libmbim: " Nathaniel Roach
2015-08-25  5:56   ` Yegor Yefremov
2015-08-25 18:49   ` Thomas Petazzoni
2015-08-25  5:56 ` [Buildroot] [PATCH 1/3] [v3] libgudev: New package Yegor Yefremov
2015-08-25 18:48 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150825204833.57f5a846@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox