From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] packages/linux-pam: disable when using musl
Date: Wed, 26 Aug 2015 15:28:42 +0200 [thread overview]
Message-ID: <20150826152842.1fb22ddd@free-electrons.com> (raw)
In-Reply-To: <1440109933-6123-1-git-send-email-brendanheading@gmail.com>
Brendan,
On Thu, 20 Aug 2015 23:32:13 +0100, Brendan Heading wrote:
> Fixes: http://autobuild.buildroot.net/results/e33/e337d69420ad00b2cc4017d639a31803926f2353/
>
> linux-pam needs some surgery to build under musl, so for the time being
> disable it until the issues are solved. Also disables dependent package
> python-pam, and dependent suboptions under openvmtools, rsh-redone and
> util-linux.
>
> ---
> v1 -> v2 - added missing comments to document that packages require
> non-musl (ie uclibc or (e)glibc) toolchains.
> ---
>
> Signed-off-by: Brendan Heading <brendanheading@gmail.com>
Your SoB line should be before the first "---" otherwise it gets
stripped by Git when applying.
> + depends on !BR2_TOOLCHAIN_USES_MUSL # linux-pam
We use a space before the comment, not a tab.
I've applied to master after fixing those minor nits.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-08-26 13:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 22:32 [Buildroot] [PATCH v2 1/1] packages/linux-pam: disable when using musl Brendan Heading
2015-08-26 13:28 ` Thomas Petazzoni [this message]
2015-08-26 17:06 ` Brendan Heading
2015-08-26 17:26 ` Thomas Petazzoni
2015-08-26 17:44 ` Brendan Heading
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150826152842.1fb22ddd@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox