Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] pacakge/qt5/qt5base: fix build with ccache
Date: Fri, 28 Aug 2015 11:57:49 +0200	[thread overview]
Message-ID: <20150828115749.6e4b4481@free-electrons.com> (raw)
In-Reply-To: <1440755211-46875-1-git-send-email-benoit@wsystem.com>

Dear Beno?t Th?baudeau,

On Fri, 28 Aug 2015 11:46:51 +0200, Beno?t Th?baudeau wrote:

> +diff --git a/mkspecs/features/device_config.prf b/mkspecs/features/device_config.prf
> +index cd3a0cf..eee4ac6 100644
> +--- a/mkspecs/features/device_config.prf
> ++++ b/mkspecs/features/device_config.prf
> +@@ -19,10 +19,15 @@ defineTest(deviceSanityCheckCompiler) {
> +     else: \
> +         sfx =
> + 
> ++    # Build the compiler filename using the first value in QMAKE_CXX in order to
> ++    # support tools like ccache, which give QMAKE_CXX values of the form:
> ++    #     ccache <path_to_compiler>
> ++    compiler = $$first(QMAKE_CXX)$$sfx

Then wouldn't it make more sense to use the last() function, to use the
last value rather than the first, and actual check the compiler rather
than ccache?

	compiler = $$last(QMAKE_CXX)$$sfx

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-08-28  9:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-28  9:46 [Buildroot] [PATCH v2] pacakge/qt5/qt5base: fix build with ccache Benoît Thébaudeau
2015-08-28  9:57 ` Thomas Petazzoni [this message]
2015-08-28 10:02   ` Benoît Thébaudeau
2015-08-28 10:05     ` Thomas Petazzoni
2015-08-28 13:39 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150828115749.6e4b4481@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox