Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Adding the Scrypt key derivation library.
Date: Fri, 28 Aug 2015 15:38:37 +0200	[thread overview]
Message-ID: <20150828153837.23d25cbc@free-electrons.com> (raw)
In-Reply-To: <CANeaEXGaudiymi+4JKxCvLTJVqBfckNWCqT+DPMBOWJJsMBuZw@mail.gmail.com>

Dear Parnell Springmeyer,

Thanks for your contribution!

You should normally send patches inline (using git send-email) rather
than as an attachment. This allows to more easily review your patch by
simply replying to your e-mail.

That being said, for this first patch, I applied it to our next branch,
after doing quite a few changes:

    [Thomas:
      - move from "Libraries -> Crypto" to "System tools", since it only
        installs one binary, scrypt, and no library.
      - bump from 1.1.6 to 1.2.0
      - add comment in the .hash file explaining where the hash is coming
        from.
      - add missing dependency on OpenSSL
      - use BSD-2c as the license code, instead of BSD2
      - use 'main.c' as the license file.]

I messed up a bit when committing, since I committed your original
patch, and then separately my changes. But at least this way you can
clearly see what I have changed:

  http://git.buildroot.net/buildroot/commit/?h=next&id=84face61cf1dfefe864d6d47976932a32bbde9f2
  http://git.buildroot.net/buildroot/commit/?h=next&id=0d83de383224c65ec250a005130b1d3cc6fd6d76

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2015-08-28 13:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-08 18:02 [Buildroot] [PATCH 1/1] Adding the Scrypt key derivation library Parnell Springmeyer
2015-08-28 13:38 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150828153837.23d25cbc@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox