From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC PATCH] pkg-generic: detect incorrectly used package
Date: Fri, 28 Aug 2015 19:45:34 +0200 [thread overview]
Message-ID: <20150828194534.578b69c5@free-electrons.com> (raw)
In-Reply-To: <55E06A5C.4020409@imgtec.com>
Dear Vicente Olivert Riera,
On Fri, 28 Aug 2015 15:04:12 +0100, Vicente Olivert Riera wrote:
> since there are certain packages which don't start by BR2_PACKAGE_ (i.e.
> BR2_TOOLCHAIN_EXTERNAL), I would suggest you to make this change:
>
> On 08/28/2015 02:45 PM, Vicente Olivert Riera wrote:
> >> + $(Q)if test "$(TYPE)" = "target" -a -z "$(BR2_PACKAGE_$(PKG))" ; then \
>
> to:
>
> + $(Q)if test "$(TYPE)" = "target" -a -z "$(BR2_PACKAGE_$(PKG))" \
> + -a -z "$(BR2_$(PKG))" ; then \
This only fixes the toolchain case, but not the Linux kernel case, or
the bootloader case. I've sent a v2 of the patch that re-uses some
existing mechanism of the package infrastructure to known the Config.in
option associated to the package being built. I believe it's nicer.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-08-28 17:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 13:25 [Buildroot] [RFC PATCH] pkg-generic: detect incorrectly used package Thomas Petazzoni
2015-08-28 13:45 ` Vicente Olivert Riera
2015-08-28 14:03 ` Thomas Petazzoni
2015-08-28 14:04 ` Vicente Olivert Riera
2015-08-28 17:45 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150828194534.578b69c5@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox