From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next 05/10] package/libcodec2: new package
Date: Sat, 29 Aug 2015 12:42:18 +0200 [thread overview]
Message-ID: <20150829124218.7059b957@free-electrons.com> (raw)
In-Reply-To: <1439317015-8031-6-git-send-email-bernd.kuhls@t-online.de>
Dear Bernd Kuhls,
On Tue, 11 Aug 2015 20:16:50 +0200, Bernd Kuhls wrote:
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/Config.in | 1 +
> package/libcodec2/0001-cross.patch | 44 +++++++++++++++++++++++++++
> package/libcodec2/0002-disable-unittest.patch | 13 ++++++++
> package/libcodec2/Config.in | 7 +++++
> package/libcodec2/libcodec2.mk | 23 ++++++++++++++
> 5 files changed, 88 insertions(+)
> create mode 100644 package/libcodec2/0001-cross.patch
> create mode 100644 package/libcodec2/0002-disable-unittest.patch
> create mode 100644 package/libcodec2/Config.in
> create mode 100644 package/libcodec2/libcodec2.mk
The two patches you added were not written in a way that makes them
upstreamable. Since upstream seems to be active, this is a little bit
sad.
So, I've replaced them by patches that can actually be upstream:
* For generate_cookbook, I've added a patch that integrates the
AX_CC_FOR_BUILD Autoconf macro from the GNU Autoconf Archive, and
use that to build generate_cookbook.
* For the unit tests, I've simply added a --enable/--disable option.
Could you take care of pushing the patches upstream? Another patch that
would be useful to push upstream is a patch to pass the subdir-objects
automake option, which would avoid a huge amount of warning when
autoreconfiguring the package.
I've applied your patch with those changes, to the next branch. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-08-29 10:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 18:16 [Buildroot] [PATCH/next 00/10] package/freeswitch: new package Bernd Kuhls
2015-08-11 18:16 ` [Buildroot] [PATCH/next 01/10] package/libldns: " Bernd Kuhls
2015-08-28 18:36 ` Thomas Petazzoni
2015-08-11 18:16 ` [Buildroot] [PATCH/next 02/10] package/libyuv: " Bernd Kuhls
2015-08-28 19:18 ` Thomas Petazzoni
2015-08-11 18:16 ` [Buildroot] [PATCH/next 03/10] package/libsilk: " Bernd Kuhls
2015-08-29 8:34 ` Thomas Petazzoni
2015-08-11 18:16 ` [Buildroot] [PATCH/next 04/10] package/libbroadvoice: " Bernd Kuhls
2015-08-29 9:49 ` Thomas Petazzoni
2015-08-11 18:16 ` [Buildroot] [PATCH/next 05/10] package/libcodec2: " Bernd Kuhls
2015-08-29 10:42 ` Thomas Petazzoni [this message]
2015-08-11 18:16 ` [Buildroot] [PATCH/next 06/10] package/libg7221: " Bernd Kuhls
2015-08-29 10:45 ` Thomas Petazzoni
2015-08-11 18:16 ` [Buildroot] [PATCH/next 07/10] package/libilbc: " Bernd Kuhls
2015-08-29 10:54 ` Thomas Petazzoni
2015-08-11 18:16 ` [Buildroot] [PATCH/next 08/10] package/libopenh264: " Bernd Kuhls
2015-08-29 12:49 ` Thomas Petazzoni
2015-08-11 18:16 ` [Buildroot] [PATCH/next 09/10] package/libsoundtouch: " Bernd Kuhls
2015-08-29 12:56 ` Thomas Petazzoni
2015-08-11 18:16 ` [Buildroot] [PATCH/next 10/10] package/freeswitch: " Bernd Kuhls
2015-08-29 13:41 ` Thomas Petazzoni
2015-08-29 21:43 ` Bernd Kuhls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150829124218.7059b957@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox