From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] ibrcommon: new package
Date: Sat, 29 Aug 2015 16:46:58 +0200 [thread overview]
Message-ID: <20150829164658.32312d79@free-electrons.com> (raw)
In-Reply-To: <1439037734-10302-1-git-send-email-tom_a_sparks@yahoo.com.au>
Dear Tom Sparks,
On Sat, 8 Aug 2015 22:42:14 +1000, Tom Sparks wrote:
> Signed-off-by: Tom Sparks <tom_a_sparks@yahoo.com.au>
> ---
> package/ibrcommon/Config.in | 17 +++++++++++++++++
> package/ibrcommon/ibrcommon.mk | 30 ++++++++++++++++++++++++++++++
> 2 files changed, 47 insertions(+)
> create mode 100644 package/ibrcommon/Config.in
> create mode 100644 package/ibrcommon/ibrcommon.mk
Thanks for your contribution! I applied your patch to the next branch
(so this patch will be part of the 2015.11 release in november, but
not of the upcoming 2015.08 release).
However, I had to do quite a few changes compared to your submission:
[Thomas:
- add package in package/Config.in, to make it visible in menuconfig
- make the openssl, libnl and libxml2 dependencies optional, since
they are definitely not mandatory
- add README to the license files, since it contains useful
licensing related information.
- remove custom INSTALL_STAGING_OPTS and INSTALL_TARGET_OPTS since
the package uses automake.
- add missing final newline in Config.in and .mk file.]
You can look at the final commit at:
http://git.buildroot.net/buildroot/commit/?h=next&id=d45e6bf09d0413742457b371762b09e69cf22829
and compare it to your original submission, to see the changes that
have been made. The most important issues were: 1/ that
package/ibrcommon/Config.in was not included in package/Config.in and
2/ that the openssl, libxml2 and libnl dependencies were optional not
mandatory.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-08-29 14:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-08 12:42 [Buildroot] [PATCH 1/1] ibrcommon: new package Tom Sparks
2015-08-29 14:46 ` Thomas Petazzoni [this message]
2015-08-29 16:16 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150829164658.32312d79@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox