Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv3 1/2] udisks: bump to version 1.0.5
Date: Wed, 2 Sep 2015 16:13:38 +0200	[thread overview]
Message-ID: <20150902161338.076139f5@free-electrons.com> (raw)
In-Reply-To: <55E703D1.408@imgtec.com>

Dear Vicente Olivert Riera,

On Wed, 2 Sep 2015 15:12:33 +0100, Vicente Olivert Riera wrote:

> >> +	# udisks needs libgudev which is provided by eudev. But, if you are
> >> +	# using systemd, since they removed libgudev from it, you need to
> >> +	# install the libgudev package to satisfy this dependency.
> > 
> > I think the wording is not quite good yet. The sentence "udisks needs
> > libgudev which is provided by eudev" is wrong, because libgudev can
> > also be provided by libgudev. What about instead:
> > 
> > 	# When eudev is used as the udev provider, libgudev is
> > 	# automatically provided as it is part of eudev. However, when
> > 	# systemd is used as the udev provider, libgudev is not
> > 	# provided, and needs to be built separately. This is why we
> > 	# select the libgudev package only if systemd is used.
> > 
> > (Or something along those lines, my english is not perfect, for sure).
> > 
> > Thomas
> > 
> 
> your explanation looks better to me. Care to use --amend before pushing
> the changes, please? :-P Or do you want me to send a v4 for this?

I may not be the one applying the changes: Peter is back online and
available to merge things, so he might be the one merging the patches.
So please send a v4.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-09-02 14:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-02 10:50 [Buildroot] [PATCHv3 1/2] udisks: bump to version 1.0.5 Vicente Olivert Riera
2015-09-02 10:50 ` [Buildroot] [PATCHv3 2/2] udisks: fix build with newer glibc versions Vicente Olivert Riera
2015-09-02 14:09 ` [Buildroot] [PATCHv3 1/2] udisks: bump to version 1.0.5 Thomas Petazzoni
2015-09-02 14:12   ` Vicente Olivert Riera
2015-09-02 14:13     ` Thomas Petazzoni [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-09-02 10:39 Vicente Olivert Riera
2015-09-02 10:36 Vicente Olivert Riera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150902161338.076139f5@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox