From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv5 3/4] Makefile: implement a size-stats target
Date: Thu, 3 Sep 2015 12:29:05 +0200 [thread overview]
Message-ID: <20150903102905.GC3689@free.fr> (raw)
In-Reply-To: <1441228505-23235-4-git-send-email-thomas.petazzoni@free-electrons.com>
Thomas, All,
On 2015-09-02 23:15 +0200, Thomas Petazzoni spake thusly:
> This commit implements a size-stats target that calls the script of
> the same name to generate the graph and CSV files related to package
> and file sizes.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Reviewed-by: Ryan Barnett <ryanbarnett3@gmail.com>
> Tested-by: Ryan Barnett <ryanbarnett3@gmail.com>
Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
I would however have called this something like graph-sizes, so it is in
line with the other graph-generating targets.
Otherwise:
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> Makefile | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 9a6e9c0..4a33495 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -685,6 +685,13 @@ graph-depends: graph-depends-requirements
> |tee $(GRAPHS_DIR)/$(@).dot \
> |dot $(BR2_GRAPH_DOT_OPTS) -T$(BR_GRAPH_OUT) -o $(GRAPHS_DIR)/$(@).$(BR_GRAPH_OUT)
>
> +size-stats:
> + $(Q)mkdir -p $(GRAPHS_DIR)
> + $(Q)$(TOPDIR)/support/scripts/size-stats --builddir $(BASE_DIR) \
> + --graph $(BASE_DIR)/graphs/graph-size.$(BR_GRAPH_OUT) \
> + --file-size-csv $(BASE_DIR)/build/file-size-stats.csv \
> + --package-size-csv $(BASE_DIR)/build/package-size-stats.csv
> +
> else # ifeq ($(BR2_HAVE_DOT_CONFIG),y)
>
> all: menuconfig
> @@ -903,6 +910,7 @@ endif
> @echo ' manual-epub - build manual in ePub'
> @echo ' graph-build - generate graphs of the build times'
> @echo ' graph-depends - generate graph of the dependency tree'
> + @echo ' size-stats - generate stats of the filesystem size'
> @echo ' list-defconfigs - list all defconfigs (pre-configured minimal systems)'
> @echo
> @echo 'Miscellaneous:'
> --
> 2.5.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-09-03 10:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 21:15 [Buildroot] [PATCHv5 0/4] Generate package size statistics Thomas Petazzoni
2015-09-02 21:15 ` [Buildroot] [PATCHv5 1/4] pkg-generic: add step_pkg_size global instrumentation hook Thomas Petazzoni
2015-09-03 10:25 ` Yann E. MORIN
2015-09-09 13:11 ` Vicente Olivert Riera
2015-09-09 13:46 ` Thomas Petazzoni
2015-09-09 13:50 ` Vicente Olivert Riera
2015-09-09 14:10 ` Thomas Petazzoni
2015-09-02 21:15 ` [Buildroot] [PATCHv5 2/4] support/scripts: add size-stats script Thomas Petazzoni
2015-09-03 10:27 ` Yann E. MORIN
2015-09-02 21:15 ` [Buildroot] [PATCHv5 3/4] Makefile: implement a size-stats target Thomas Petazzoni
2015-09-03 10:29 ` Yann E. MORIN [this message]
2015-09-03 12:21 ` Thomas Petazzoni
2015-09-03 12:36 ` Yann E. MORIN
2015-09-02 21:15 ` [Buildroot] [PATCHv5 4/4] docs/manual: add section about size graphing Thomas Petazzoni
2015-09-03 10:37 ` Yann E. MORIN
2015-09-03 10:43 ` Yann E. MORIN
2015-09-15 2:54 ` Ryan Barnett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150903102905.GC3689@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox