From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] Fix elf2flt build when LTO is enabled
Date: Sun, 6 Sep 2015 15:24:01 +0200 [thread overview]
Message-ID: <20150906152401.67d5df05@free-electrons.com> (raw)
In-Reply-To: <1441470809-23403-1-git-send-email-public.douglas.raillard@gmail.com>
Dear Douglas RAILLARD,
On Sat, 5 Sep 2015 18:33:29 +0200, Douglas RAILLARD wrote:
> diff --git a/package/elf2flt/elf2flt.mk b/package/elf2flt/elf2flt.mk
> index 3fcada4..d028259 100644
> --- a/package/elf2flt/elf2flt.mk
> +++ b/package/elf2flt/elf2flt.mk
> @@ -21,6 +21,12 @@ HOST_ELF2FLT_CONF_OPTS = \
> --with-libiberty=$(HOST_BINUTILS_DIR)/libiberty/libiberty.a \
> --target=$(GNU_TARGET_NAME)
>
> +
Unnecessary new line addition.
> HOST_ELF2FLT_CONF_ENV = LIBS=-lz
>
> +ifeq ($(BR2_GCC_ENABLE_LTO),y)
> + HOST_ELF2FLT_CONF_ENV = LIBS="-lz -ldl"
Don't intend variables.
Also, please change this to:
HOST_ELF2FLT_LIBS = -lz
ifeq ($(BR2_GCC_ENABLE_LTO),y)
HOST_ELF2FLT_LIBS += -ldl
endif
HOST_ELF2FLT_CONF_ENV = LIBS="$(HOST_ELF2FLT_LIBS)"
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-09-06 13:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-05 16:33 [Buildroot] [PATCH 2/3] Fix elf2flt build when LTO is enabled Douglas RAILLARD
2015-09-06 13:24 ` Thomas Petazzoni [this message]
2015-09-06 15:48 ` [Buildroot] [PATCH v2 2/3] elf2flt: fix " Douglas RAILLARD
2015-09-06 20:51 ` Yann E. MORIN
2015-09-20 13:45 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150906152401.67d5df05@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox