From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] Fix uClibc build for ARM-nommu
Date: Sun, 6 Sep 2015 15:25:58 +0200 [thread overview]
Message-ID: <20150906152558.6472329b@free-electrons.com> (raw)
In-Reply-To: <1441470824-23456-1-git-send-email-public.douglas.raillard@gmail.com>
Dear Douglas RAILLARD,
On Sat, 5 Sep 2015 18:33:44 +0200, Douglas RAILLARD wrote:
> +# UCLIBC_HAS_CONTEXT_FUNCS is broken with Thumb and Thumb2
> +ifeq (y,$(filter y,$(BR2_ARM_INSTRUCTIONS_THUMB) $(BR2_ARM_INSTRUCTIONS_THUMB2)))
Why such a complicated condition? BR2_ARM_INSTRUCTIONS_THUMB and
BR2_ARM_INSTRUCTIONS_THUMB2 are in a "choice" ... "endchoice" block, so
only one of the two can be set to 'y' at any given time. So you can do:
ifeq ($(BR2_ARM_INSTRUCTIONS_THUMB)$(BR2_ARM_INSTRUCTIONS_THUMB2),y)
instead.
> +define UCLIBC_ARM_THUMB_CONFIG
> + $(call KCONFIG_ENABLE_OPT,COMPILE_IN_THUMB_MODE,$(@D)/.config)
> + $(call KCONFIG_DISABLE_OPT,UCLIBC_HAS_CONTEXT_FUNCS,$(@D)/.config)
> +endef
> +endif
Other than that, it looks good to me.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-09-06 13:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-05 16:33 [Buildroot] [PATCH 3/3] Fix uClibc build for ARM-nommu Douglas RAILLARD
2015-09-06 13:25 ` Thomas Petazzoni [this message]
2015-09-06 15:35 ` Douglas RAILLARD
2015-09-06 16:01 ` Thomas Petazzoni
2015-09-06 20:44 ` Douglas RAILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150906152558.6472329b@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox