Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] stress-ng: Depend on kernel headers >= 3.3
Date: Fri, 11 Sep 2015 19:59:28 +0200	[thread overview]
Message-ID: <20150911195928.51c339dc@free-electrons.com> (raw)
In-Reply-To: <1441988351-9923-1-git-send-email-corjon.j@ecagroup.com>

Julien,

On Fri, 11 Sep 2015 18:19:11 +0200, Julien Corjon wrote:
> perf.c need PERF_COUNT_HW_REF_CPU_CYCLES instruction which is available
> only since 3.3 kernel version
> 
> Signed-off-by: Julien Corjon <corjon.j@ecagroup.com>
> ---
>  package/stress-ng/Config.in | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/package/stress-ng/Config.in b/package/stress-ng/Config.in
> index cdf9984..1e475b1 100644
> --- a/package/stress-ng/Config.in
> +++ b/package/stress-ng/Config.in
> @@ -4,8 +4,8 @@ config BR2_PACKAGE_STRESS_NG
>  	# disabled on musl: stress-malloc.c needs mallopt() and M_MMAP_THRESHOLD
>  	# disabled on uClibc: stress-aio.c needs aio.h
>  	depends on BR2_TOOLCHAIN_USES_GLIBC
> -	# perf.c needs PERF_COUNT_HW_STALLED_CYCLES_FRONTEND
> -	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0
> +	# perf.c needs PERF_COUNT_HW_REF_CPU_CYCLES
> +	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_3

This seems wrong, because stress-ng.h has the definitions for all the
PERF_COUNT_* values:

#if defined(__linux__) && defined(__NR_perf_event_open)
#define STRESS_PERF_STATS       (1)
#define STRESS_PERF_INVALID     (~0ULL)
enum {
        STRESS_PERF_HW_CPU_CYCLES = 0,
        STRESS_PERF_HW_INSTRUCTIONS,
        STRESS_PERF_HW_CACHE_REFERENCES,
        STRESS_PERF_HW_CACHE_MISSES,
        STRESS_PERF_HW_BRANCH_INSTRUCTIONS,
        STRESS_PERF_HW_BRANCH_MISSES,
        STRESS_PERF_HW_BUS_CYCLES,
        STRESS_PERF_HW_REF_CPU_CYCLES,
        STRESS_PERF_HW_STALLED_CYCLES_FRONTEND,
        STRESS_PERF_HW_STALLED_CYCLES_BACKEND,

        STRESS_PERF_SW_PAGE_FAULTS_MIN,
        STRESS_PERF_SW_PAGE_FAULTS_MAJ,
        STRESS_PERF_SW_CONTEXT_SWITCHES,
        STRESS_PERF_SW_CPU_MIGRATIONS,
        STRESS_PERF_SW_ALIGNMENT_FAULTS,

Can you figure out why it doesn't get used?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-09-11 17:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-11 16:19 [Buildroot] [PATCH 1/1] stress-ng: Depend on kernel headers >= 3.3 Julien Corjon
2015-09-11 17:59 ` Thomas Petazzoni [this message]
2015-09-12 10:26   ` Romain Naour
2015-09-13 14:27     ` Romain Naour
2015-09-12 10:19 ` Vicente Olivert Riera
2015-09-14  7:43 ` [Buildroot] [PATCH v2] " Julien Corjon
2015-09-14  8:59   ` Vicente Olivert Riera
2015-09-14 12:36   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150911195928.51c339dc@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox