From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] add python simple template module
Date: Sun, 13 Sep 2015 20:04:43 +0200 [thread overview]
Message-ID: <20150913200443.38a3512d@free-electrons.com> (raw)
In-Reply-To: <1442162503-5817-1-git-send-email-stevecalfee@gmail.com>
Dear Steve Calfee,
The title of the commit should be:
python-pyratemp: new package
On Sun, 13 Sep 2015 09:41:43 -0700, Steve Calfee wrote:
> diff --git a/package/python-pyratemp/python-pyratemp.hash b/package/python-pyratemp/python-pyratemp.hash
> new file mode 100644
> index 0000000..0abb9e0
> --- /dev/null
> +++ b/package/python-pyratemp/python-pyratemp.hash
> @@ -0,0 +1,4 @@
> +# From http://www.simple-is-better.org/template
> +# Locally calculated:
Having those two comments together do not make sense. Either the hash
is provided by the official upstream website and you should write the
first line, or the hash is not available from the upstream website, in
which case you use a locally calculated hash.
> +sha256 c45ed656ada482a02fe780495f37a695e7671accb04f918f7e7f18abf877bc71 pyratemp-0.3.2.tgz
> +
Unneeded empty line.
Could you fix those minor issues, as well as Yegor's comment, and send
a v2 version of this patch?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-09-13 18:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 16:41 [Buildroot] [PATCH 1/1] add python simple template module Steve Calfee
2015-09-13 17:05 ` Yegor Yefremov
2015-09-13 18:04 ` Thomas Petazzoni [this message]
2015-09-15 0:41 ` Steve Calfee
2015-09-15 6:23 ` Yegor Yefremov
2015-09-15 15:56 ` Steve Calfee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150913200443.38a3512d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox