Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Enable vlc to run as root
Date: Tue, 15 Sep 2015 23:11:24 +0200	[thread overview]
Message-ID: <20150915231124.76245a4f@free-electrons.com> (raw)
In-Reply-To: <55F821BD.4010006@synopsys.com>

Hello,

On Tue, 15 Sep 2015 14:48:45 +0100, Joao Pinto wrote:

> >> This patch has the goal of enabling vlc to be ran as root.
> >>
> >> Signed-off-by: jpinto <jpinto@synopsys.com>
> >> Tested-by: jpinto <jpinto@synopsys.com>
> > 
> > Use your full name here.
> 
> Ok, in future patches I will do it.

We actually need your full name for this patch as well. Signed-off-by
is a legal statement, so we need people to use their full name.

Can you send a v2 of your patch?

> > I don't know if running vlc as root is disabled by default due to
> > security reasons, but if so, perhaps we could do this selectable by the
> > user via menuconfig.

I don't think this is necessary. We don't do that for any of the other
packages in Buildroot. So from my point of view, the patch is OK, it
only needs to be resubmitted with a full name (as the From and in
Signed-off-by).

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2015-09-15 21:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-15 13:20 [Buildroot] [PATCH] Enable vlc to run as root jpinto
2015-09-15 13:33 ` Vicente Olivert Riera
2015-09-15 13:48   ` Joao Pinto
2015-09-15 21:11     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150915231124.76245a4f@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox