From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/4] package/hplip: Un-deprecate and bump version to 3.15.7
Date: Wed, 16 Sep 2015 23:50:17 +0200 [thread overview]
Message-ID: <20150916235017.13de99e2@free-electrons.com> (raw)
In-Reply-To: <1442319834-20549-3-git-send-email-olivier.schonken@gmail.com>
Dear Olivier Schonken,
On Tue, 15 Sep 2015 14:23:52 +0200, Olivier Schonken wrote:
> diff --git a/package/hplip/hplip.hash b/package/hplip/hplip.hash
> index fb7d4e7..98f4262 100644
> --- a/package/hplip/hplip.hash
> +++ b/package/hplip/hplip.hash
> @@ -1,2 +1,2 @@
> # Locally computed:
> -sha256 a8122cd824398ac6374154f86152e24fdf5c0100b5c1d6518e853308362e627d hplip-3.13.10.tar.gz
> +sha256 d310903048f3600f93422e5a8c39ddd682511e0849cd9abc5e943f9a10bdd49d hplip-3.15.7.tar.gz
> diff --git a/package/hplip/hplip.mk b/package/hplip/hplip.mk
> index 2cdddca..65f57e2 100644
> --- a/package/hplip/hplip.mk
> +++ b/package/hplip/hplip.mk
> @@ -4,7 +4,7 @@
> #
> ################################################################################
>
> -HPLIP_VERSION = 3.13.10
> +HPLIP_VERSION = 3.15.7
> HPLIP_SITE = http://downloads.sourceforge.net/hplip/hplip
> HPLIP_AUTORECONF = YES
> HPLIP_DEPENDENCIES = cups libusb jpeg
> @@ -29,6 +29,8 @@ HPLIP_CONF_OPTS = \
> --with-sysroot=$(STAGING_DIR) \
> --includedir=$(STAGING_DIR)/usr/include
I never saw this and 0001-fix-make.patch, but it's actually not the
proper solution. --includedir should normally remain /usr/include. But
oh well, it works this way, and it is not changed by your patch, so
let's keep it as is for now.
> +HPLIP_MAKE_OPTS += LDFLAGS+=-lpthread
Why are you adding this? I did a build after removing this line, and it
built fine for me (uClibc toolchain). Could you add a comment above the
line to explain which cases it is fixing?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-09-16 21:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 12:23 [Buildroot] [PATCH v2 0/5] Buildroot printing with Cups Olivier Schonken
2015-09-15 12:23 ` [Buildroot] [PATCH v2 1/4] package/cups: Un-deprecate, and update CUPS to 2.1.0 Olivier Schonken
2015-09-16 21:34 ` Thomas Petazzoni
2015-09-15 12:23 ` [Buildroot] [PATCH v2 2/4] package/hplip: Un-deprecate and bump version to 3.15.7 Olivier Schonken
2015-09-16 21:50 ` Thomas Petazzoni [this message]
2015-09-15 12:23 ` [Buildroot] [PATCH v2 3/4] package/gutenprint: Un-deprecate and bump version to 5.2.10 Olivier Schonken
2015-09-15 12:23 ` [Buildroot] [PATCH v2 4/4] package/cups-filters: Add new package cups-filters 1.0.74 Olivier Schonken
2015-09-16 21:58 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150916235017.13de99e2@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox