Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] sysvinit: build fixed for arm64 architectures
Date: Thu, 17 Sep 2015 16:56:24 +0300	[thread overview]
Message-ID: <20150917135624.GQ11632@tarshish> (raw)
In-Reply-To: <2cd1307d42dd411b54c212cc53439d1ead0af01c.1442497341.git.jpinto@synopsys.com>

Hi Joao,

On Thu, Sep 17, 2015 at 02:46:02PM +0100, jpinto wrote:
> sysvinit was not able to be built for arm64 architectures. This patch was made 
> to fix the problem.
> 
> Signed-off-by: Joao Pinto <jpinto@synopsys.com>
> ---
>  package/sysvinit/0001-fix-libcrypt-test.patch | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/package/sysvinit/0001-fix-libcrypt-test.patch b/package/sysvinit/0001-fix-libcrypt-test.patch
> index 207270d..7233d38 100644
> --- a/package/sysvinit/0001-fix-libcrypt-test.patch
> +++ b/package/sysvinit/0001-fix-libcrypt-test.patch
> @@ -1,17 +1,25 @@
>  Make the libcrypt test somewhat cross-compilation compliant
>  
>  Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> +Signed-off-by: Joao Pinto <jpinto@synopsys.com>
>  
>  Index: b/src/Makefile
>  ===================================================================
>  --- a/src/Makefile
>  +++ b/src/Makefile
> -@@ -78,7 +78,7 @@
> +@@ -78,7 +78,14 @@
>   endif
>   
>   # Additional libs for GNU libc.
>  -ifneq ($(wildcard /usr/lib*/libcrypt.a),)
> ++inc_additional_lib =
>  +ifneq ($(wildcard $(SYSROOT)/usr/lib*/libcrypt.a),)
> ++  inc_additional_lib = yes
> ++else ifneq ($(wildcard $(SYSROOT)/usr/lib*/aarch64*/libcrypt.a),)

This looks to specific to that toolchain. Why not generalize

 else ifneq ($(wildcard $(SYSROOT)/usr/lib*/*/libcrypt.a),)

?

baruch

> ++  inc_additional_lib = yes
> ++endif
> ++
> ++ifdef inc_additional_lib
>     SULOGINLIBS	+= -lcrypt
>   endif

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2015-09-17 13:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17 13:46 [Buildroot] [PATCH] sysvinit: build fixed for arm64 architectures jpinto
2015-09-17 13:56 ` Baruch Siach [this message]
2015-09-17 14:19   ` Joao Pinto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150917135624.GQ11632@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox