Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] Add dependency on bash to gzip for runtime
Date: Thu, 17 Sep 2015 19:20:03 +0300	[thread overview]
Message-ID: <20150917162003.GT11632@tarshish> (raw)
In-Reply-To: <alpine.DEB.2.02.1509171814510.13941@orcam81.orcam.lan>

Hi Yonatan,

On Thu, Sep 17, 2015 at 06:16:42PM +0300, Jonathan Ben Avraham wrote:
> On Thu, 17 Sep 2015, Baruch Siach wrote:
> 
> >Date: Thu, 17 Sep 2015 18:01:12 +0300
> >From: Baruch Siach <baruch@tkos.co.il>
> >To: Jonathan Ben-Avraham <yba@tkos.co.il>
> >Cc: buildroot at buildroot.org
> >Subject: Re: [Buildroot] [PATCH 1/2] Add dependency on bash to gzip for
> >    runtime
> >
> >On Thu, Sep 17, 2015 at 05:46:32PM +0300, Jonathan Ben-Avraham wrote:
> >>From: Jonathan Ben Avraham <yba@tkos.co.il>
> >>
> >>The GNU gzip package provides eleven executable files, all but one of
> >>which are bash shell scripts. If we allow inclusion of gzip without
> >>bash, then on executing commands such as lxc-checkconfig that actually
> >>use these shell scripts, you will get errors like 'zgrep: not found',
> >>even though the zgrep executable is in PATH.
> >
> >Which /bin/sh shell show this problem?
> >
> >On my host the command
> >
> >  busybox sh /bin/zgrep pattern file.gz
> >
> >and also
> >
> >  dash /bin/zgrep pattern file.gz
> >
> >work as expected.
> 
> You tested *all* of the scripts or just this one?

I didn't test all of them. I'm just trying to reproduce the 'zgrep: not found' 
problem that you report in the commit log, to see what went wrong.

> What if ash breaks even *one*?

Then we should probably patch the problem and send upstream. gzip bundled 
scripts are pretty trivial, and AFAICS, should work under any POSIX-like 
shell.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2015-09-17 16:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17 14:46 [Buildroot] [PATCH 1/2] Add dependency on bash to gzip for runtime Jonathan Ben-Avraham
2015-09-17 14:46 ` [Buildroot] [PATCH 2/2] Add dependency on gzip to lxc " Jonathan Ben-Avraham
2015-09-17 15:03   ` Baruch Siach
2015-09-17 15:20     ` Jonathan Ben Avraham
2015-09-17 17:16       ` Thomas Petazzoni
2015-09-17 15:01 ` [Buildroot] [PATCH 1/2] Add dependency on bash to gzip " Baruch Siach
2015-09-17 15:16   ` Jonathan Ben Avraham
2015-09-17 16:20     ` Baruch Siach [this message]
2015-09-17 16:33       ` Jonathan Ben Avraham
2015-09-17 17:23         ` Thomas Petazzoni
2015-09-17 19:04           ` Baruch Siach
2015-09-17 20:15             ` Thomas Petazzoni
2015-09-19 20:36               ` Jonathan Ben Avraham
2015-09-20  8:22                 ` Thomas Petazzoni
2015-09-20 10:39                   ` Arnout Vandecappelle
2015-09-20 11:16                     ` Thomas Petazzoni
2015-09-20 11:35                       ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150917162003.GT11632@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox