From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Thu, 17 Sep 2015 19:16:00 +0200 Subject: [Buildroot] [PATCH 2/2] Add dependency on gzip to lxc for runtime In-Reply-To: References: <1442501193-6059-1-git-send-email-yba@tkos.co.il> <1442501193-6059-2-git-send-email-yba@tkos.co.il> <20150917150353.GS11632@tarshish> Message-ID: <20150917191600.06f9557d@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Thu, 17 Sep 2015 18:20:34 +0300 (IDT), Jonathan Ben Avraham wrote: > > Date: Thu, 17 Sep 2015 18:03:53 +0300 > > From: Baruch Siach > > To: Jonathan Ben-Avraham > > Cc: buildroot at buildroot.org > > Subject: Re: [Buildroot] [PATCH 2/2] Add dependency on gzip to lxc for runtime > > > > Hi Yonatan, > > > > On Thu, Sep 17, 2015 at 05:46:33PM +0300, Jonathan Ben-Avraham wrote: > >> From: Jonathan Ben Avraham > >> > >> lxc executables such as lxc-checkconfig require scripts provided by > >> gzip such as zgrep. > >> > >> Signed-off-by: Jonathan Ben Avraham > >> --- > >> package/lxc/Config.in | 6 ++++-- > >> 1 file changed, 4 insertions(+), 2 deletions(-) > >> > >> diff --git a/package/lxc/Config.in b/package/lxc/Config.in > >> index ffd9b4a..e774eee 100644 > >> --- a/package/lxc/Config.in > >> +++ b/package/lxc/Config.in > >> @@ -9,6 +9,7 @@ config BR2_PACKAGE_LXC > >> depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII201305 > >> depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII201405 > >> depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # libcap > >> + depends on BR2_PACKAGE_GZIP > > > > We generally use 'select' for non obvious dependencies like this one. You'll > > also need to propagate the wchar dependency of gzip here. > > I didn't use 'select' because of its implicit, sneaky nature. Bash is too > heavy to just "select" it into a rootfs without the user explicitly > putting an 'X' in the checkbox. Still, we want such dependencies to use a "select" like Baruch said. They should even be noted this way: select BR2_PACKAGE_GZIP # runtime dep only Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com