Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] host-gcc-final: don't install a potentially dead symlink
Date: Sun, 20 Sep 2015 14:35:48 +0200	[thread overview]
Message-ID: <20150920143548.498838f0@free-electrons.com> (raw)
In-Reply-To: <1442612666-19806-1-git-send-email-arnout@mind.be>

Arnout,

On Fri, 18 Sep 2015 23:44:26 +0200, Arnout Vandecappelle
(Essensium/Mind) wrote:
> gcc used to be installed into $(HOST_DIR)/usr/$(GNU_TARGET_NAME) but
> since gcc 4.9 this is no longer the case.  Therefore, the cc -> gcc
> symlink that is created in that we create in that directory is dead.
> 
> There don't seem to have been any problems due to the missing gcc and
> cc in $(HOST_DIR)/usr/$(GNU_TARGET_NAME), things seems to build fine
> without it. The cc -> gcc symlinks in general should not be needed
> anyway, since we always pass the appropriate CC variable to the
> package build system.
> 
> Therefore, let's remove the cc -> gcc symlink in
> $(HOST_DIR)/usr/$(GNU_TARGET_NAME) - also for pre-4.9 gcc versions.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> In addition to the explanation above, this patch is also preparation
> for an upcoming patch series that implements the wrapper for the
> internal toolchain. All the -gcc, -cc and -g++ instances have to be
> symlinked to the wrapper, and the original (even if it was already
> a symlink) has to be moved to *.real. So removing this redundant
> thing helps keeping the internal toolchain wrapper implementation
> a little simpler.

I've applied. We'll see what the autobuilders will say about this :-)

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2015-09-20 12:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18 21:44 [Buildroot] [PATCH v2] host-gcc-final: don't install a potentially dead symlink Arnout Vandecappelle
2015-09-20 12:35 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150920143548.498838f0@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox