From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/ibrcommon: fix basename call under musl
Date: Sun, 20 Sep 2015 14:51:33 +0200 [thread overview]
Message-ID: <20150920145133.5d83fe04@free-electrons.com> (raw)
In-Reply-To: <1442269611-30641-1-git-send-email-brendanheading@gmail.com>
Dear Brendan Heading,
On Mon, 14 Sep 2015 23:26:51 +0100, Brendan Heading wrote:
> Fixes:
> http://autobuild.buildroot.net/results/9c3/9c3889fe80e58b7a35c242332f993992044d2f6b/
>
> ibrcommon was relying on a glibc extension to basename(3) which allowed it
> to accept a const char* parameter (instead of char*). Fixed by testing
> for __GLIBC__; if not defined (such as when musl is in use) a fallback
> block is used which creates a temporary copy of the path.
>
> Signed-off-by: Brendan Heading <brendanheading@gmail.com>
> ---
> ...data-File.cpp-support-POSIX-basename-call.patch | 55 ++++++++++++++++++++++
> 1 file changed, 55 insertions(+)
> create mode 100644 package/ibrcommon/0001-ibrcommon-data-File.cpp-support-POSIX-basename-call.patch
Applied, thanks. However, I believe a better fix would be to use an
autoconf test rather than really on this crazy set of #ifdef for the
different platforms.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-09-20 12:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 22:26 [Buildroot] [PATCH 1/1] package/ibrcommon: fix basename call under musl Brendan Heading
2015-09-20 12:51 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150920145133.5d83fe04@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox