From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] micropython: Disable for Blackfin
Date: Mon, 21 Sep 2015 12:22:43 +0300 [thread overview]
Message-ID: <20150921092243.GL2782@tarshish> (raw)
In-Reply-To: <1442825517-28669-1-git-send-email-judge.packham@gmail.com>
Hi Chris,
On Mon, Sep 21, 2015 at 08:51:57PM +1200, Chris Packham wrote:
> There are two problems building micropython for Blackfin. The first is
> some printf format specifier warnings/errors that seem to be triggered
> only for that architecture/compiler. This could be worked around by
> specifying CFLAGS=-Wno-error=format.
>
> The second problem is that libffi doesn't provide the closure
> implementation on Blackfin. There is no known workaround for this issue.
>
> For now disable micropython on Blackfin.
>
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
> package/micropython/Config.in | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/micropython/Config.in b/package/micropython/Config.in
> index c62b3ab..4664494 100644
> --- a/package/micropython/Config.in
> +++ b/package/micropython/Config.in
> @@ -1,6 +1,8 @@
> config BR2_PACKAGE_MICROPYTHON
> bool "micropython"
> select BR2_PACKAGE_LIBFFI
> + # libffi doesn't provide the closure implementation on Blackfin
> + depends on !BR2_bfin
Please add the same dependency to the comment below. No need to repeat the
explanation there. The reason is that the comment is useless when the package
is disabled for the current architecture.
baruch
> depends on BR2_TOOLCHAIN_HAS_THREADS
> help
> Micro Python is a lean and fast implementation of the Python 3
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2015-09-21 9:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 4:25 [Buildroot] blackfin and micropython Chris Packham
2015-09-21 7:13 ` Thomas Petazzoni
2015-09-21 8:51 ` [Buildroot] [PATCH] micropython: Disable for Blackfin Chris Packham
2015-09-21 9:22 ` Baruch Siach [this message]
2015-09-22 4:18 ` [Buildroot] [PATCHv2] " Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921092243.GL2782@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox