From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] sysvinit: arm64 build fix
Date: Mon, 21 Sep 2015 19:32:40 +0300 [thread overview]
Message-ID: <20150921163240.GB2242@tarshish> (raw)
In-Reply-To: <875368a848cb37f12c0c13638c987ce0f7783700.1442850883.git.jpinto@synopsys.com>
Hi Joao,
[Resend with the correct list address]
On Mon, Sep 21, 2015 at 05:10:15PM +0100, Joao Pinto wrote:
> sysvinit was not able to be built for arm64 architectures.
> The package patch was changed according to the suggestion of
> Thomas Petazzoni.
>
> Signed-off-by: Joao Pinto <jpinto@synopsys.com>
> ---
> package/sysvinit/0001-fix-libcrypt-test.patch | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/package/sysvinit/0001-fix-libcrypt-test.patch b/package/sysvinit/0001-fix-libcrypt-test.patch
> index 207270d..3724110 100644
> --- a/package/sysvinit/0001-fix-libcrypt-test.patch
> +++ b/package/sysvinit/0001-fix-libcrypt-test.patch
> @@ -1,17 +1,21 @@
> Make the libcrypt test somewhat cross-compilation compliant
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> +Signed-off-by: Joao Pinto <jpinto@synopsys.com>
>
> Index: b/src/Makefile
> ===================================================================
> --- a/src/Makefile
> +++ b/src/Makefile
> -@@ -78,7 +78,7 @@
> +@@ -78,8 +78,9 @@ else
> endif
>
> # Additional libs for GNU libc.
> -ifneq ($(wildcard /usr/lib*/libcrypt.a),)
> -+ifneq ($(wildcard $(SYSROOT)/usr/lib*/libcrypt.a),)
> - SULOGINLIBS += -lcrypt
> +- SULOGINLIBS += -lcrypt
> ++HAS_LIBCRYPT=$(shell f=`mktemp` && echo 'int main(void) {}' | $(CC) -o $$f -xc - -lcrypt >/dev/null 2>&1 && echo yes && rm -f $$f)
The last '&&' causes the 'rm' command to delete the temporary file only when
the test succeeds. Should be ';' instead, I think.
baruch
> ++ifeq ($(HAS_LIBCRYPT),yes)
> ++ SULOGINLIBS += -lcrypt
> endif
>
> + all: $(BIN) $(SBIN) $(USRBIN)
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2015-09-21 16:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 15:21 [Buildroot] [PATCH v2] sysvinit: arm64 build fix Joao Pinto
2015-09-21 16:32 ` Baruch Siach [this message]
2015-09-21 16:38 ` [Buildroot] [PATCH] " Joao Pinto
2015-12-17 22:49 ` [Buildroot] [PATCH v2] " Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921163240.GB2242@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox