From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] dependencies.sh: improve the missing perl modules detection
Date: Thu, 24 Sep 2015 09:14:21 +0200 [thread overview]
Message-ID: <20150924091421.5b5956bf@free-electrons.com> (raw)
In-Reply-To: <20150924040839.GB2229@tarshish>
Hello,
On Thu, 24 Sep 2015 07:08:40 +0300, Baruch Siach wrote:
> > +# Check that the Perl installation is complete enough for Buildroot.
> > +# Here is the space-separated list of the required modules:
>
> The original comment implied that Data::Dumper is a dependency of
> host-autoconf. I guess the same is true for Thread:Queue. This is useful
> information that IMO should be preserved. Maybe some thing like the following:
Actually, the Thread::Queue module seems to be used by automake, not
autoconf. It's actually what I guessed from the bug report. And it
seems to indeed be the case:
thomas at skate:~/projets/buildroot (master)$ grep -r Queue output/build/host-autoconf-2.69/*
output/build/host-autoconf-2.69/lib/Autom4te/Channels.pm: # Redirect all channels to push messages on a Thread::Queue using
output/build/host-autoconf-2.69/lib/Autom4te/Channels.pm: # Output a message pending in a Thread::Queue.
thomas at skate:~/projets/buildroot (master)$ grep -r Queue output/build/host-automake-1.15/*
output/build/host-automake-1.15/bin/automake.in: require Thread::Queue;
output/build/host-automake-1.15/bin/automake.in: import Thread::Queue;
output/build/host-automake-1.15/bin/automake.in:# Queue to push require_conf_file requirements to.
output/build/host-automake-1.15/bin/automake.in: my $file_queue = Thread::Queue->new;
output/build/host-automake-1.15/bin/automake.in: $msg_queues{$file} = Thread::Queue->new;
output/build/host-automake-1.15/bin/automake.in: # Queue all makefiles.
output/build/host-automake-1.15/lib/Automake/Channels.pm: # Redirect all channels to push messages on a Thread::Queue using
output/build/host-automake-1.15/lib/Automake/Channels.pm: # Output a message pending in a Thread::Queue.
output/build/host-automake-1.15/old/ChangeLog.09: Cope with absent Perl modules threads and Thread::Queue.
output/build/host-automake-1.15/old/ChangeLog.09: Thread::Queue.
output/build/host-automake-1.15/old/ChangeLog.09: Thread::Queue, and output messages from such a queue, suitably
output/build/host-automake-1.15/old/ChangeLog.09: to set a Thread::Queue for channels, and to flush a queue.
output/build/host-automake-1.15/old/ChangeLog.09: threading, then use `threads' and `Thread::Queue'.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-09-24 7:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 21:13 [Buildroot] [PATCHv2] dependencies.sh: improve the missing perl modules detection Vicente Olivert Riera
2015-09-24 4:08 ` Baruch Siach
2015-09-24 7:14 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150924091421.5b5956bf@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox