From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Fix musl-based builds on ARMhf platforms.
Date: Mon, 28 Sep 2015 22:50:44 +0200 [thread overview]
Message-ID: <20150928225044.19e13433@free-electrons.com> (raw)
In-Reply-To: <1443361702-27612-1-git-send-email-vicencb@gmail.com>
Dear Vicente Bergas,
On Sun, 27 Sep 2015 14:48:22 +0100, Vicente Bergas wrote:
> When ARCH is arm and the hard-floating-point option is on executables
> expect to find the dynamic linker at /lib/ld-musl-armhf.so.1 and not
> /lib/ld-musl-arm.so.1
> There are two ways of fixing this:
> 1) Changing the actual location of the dynamic linker.
> 2) Changing the expected location of the dynamic linker.
> This patch uses option 1.
> I don't know how to do option 2 and also don't know which option is better.
>
> Signed-off-by: Vicente Bergas <vicencb@gmail.com>
> ---
> toolchain/toolchain-external/toolchain-external.mk | 2 ++
> 1 file changed, 2 insertions(+)
I've slightly tweaked the commit log and applied. In fact your
explanation about "two ways of fixing this" is not completely correct:
the dynamic linker in musl is part of the C library itself. So all what
Buildroot is doing is create a symbolic link with the name of the
dynamic linker encoded into the executables, which points to the musl C
library. So all what your patch is doing is adjusting the logic that
calculates the name of this symbolic link.
Thanks for this contribution!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-09-28 20:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-27 13:48 [Buildroot] [PATCH] Fix musl-based builds on ARMhf platforms Vicente Bergas
2015-09-28 20:50 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150928225044.19e13433@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox