[Buildroot] [PATCH v6] dependencies.sh: improve the missing perl modules detection

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Vicente,

I think the patch is great, but there are some implementation issues,
see below.

On Fri, 25 Sep 2015 11:06:25 +0100, Vicente Olivert Riera wrote:

> -# Check that the Perl installation is complete enough to build
> -# host-autoconf.
> -if ! perl  -e "require Data::Dumper" > /dev/null 2>&1 ; then
> -	echo "Your Perl installation is not complete enough, at least Data::Dumper is missing."
> -	echo "On Debian/Ubuntu distributions, install the 'perl' package."
> +# Check that the Perl installation is complete enough for Buildroot.
> +# Here is the space-separated list of the required modules.

The space-separated comment doesn't make much sense IMO.

> +required_perl_modules="Data::Dumper" # Needed to build host-autoconf
> +required_perl_modules+=" Thread:Queue" # Used by host-automake

The += operator is bash specific, and not POSIX compliant. Since this
dependencies.sh script specifies #!/bin/sh, you're not guaranteed to be
executed with bash.

> +
> +# This variable will keep the modules that are missing in your system.
> +missing_perl_modules=""
> +
> +for pm in $required_perl_modules ; do
> +	if ! perl  -e "require $pm" > /dev/null 2>&1 ; then
> +		missing_perl_modules+=" $pm"

Ditto.

> +	fi
> +done
> +
> +if [ -n "$missing_perl_modules" ] ; then
> +	echo "Your Perl installation is not complete enough; at least the following"
> +	echo "modules are missing:"
> +	echo ""

Quotes not needed here, just "echo" is sufficient.

> +	for pm in $missing_perl_modules ; do
> +		echo -e "\t $pm"
> +	done
> +	echo ""

Ditto.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com