From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] libbluray: add optional fontconfig dependency
Date: Tue, 29 Sep 2015 19:41:54 +0200 [thread overview]
Message-ID: <20150929194154.5377bd2a@free-electrons.com> (raw)
In-Reply-To: <c0676cbc3b883de88e98c9ba28d8023f17cb5e88.1443531503.git.baruch@tkos.co.il>
Baruch,
On Tue, 29 Sep 2015 15:58:22 +0300, Baruch Siach wrote:
> diff --git a/package/libbluray/libbluray.mk b/package/libbluray/libbluray.mk
> index e10f7dbc8c73..f6a501a1083f 100644
> --- a/package/libbluray/libbluray.mk
> +++ b/package/libbluray/libbluray.mk
> @@ -24,6 +24,12 @@ else
> LIBBLURAY_CONF_OPTS += --without-freetype
> endif
>
> +ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
> +LIBBLURAY_DEPENDENCIES += fontconfig
> +else
> +LIBBLURAY_CONF_OPTS += --without-fontconfig
> +endif
I would prefer to have an explicit --with-fontconfig when
BR2_PACKAGE_FONTCONFIG=y. I know it's not the case for the other
dependencies already handled by libbluray.mk, so I've applied your
patch as is, and my comment can be fixed for all optional dependencies
of libbluray in a separate patch.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-09-29 17:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 12:58 [Buildroot] [PATCH 1/2] libbluray: add optional fontconfig dependency Baruch Siach
2015-09-29 12:58 ` [Buildroot] [PATCH 2/2] libbluray: disable BD-Java Baruch Siach
2015-09-29 17:42 ` Thomas Petazzoni
2015-09-29 17:41 ` Thomas Petazzoni [this message]
2015-09-29 18:51 ` [Buildroot] [PATCH 1/2] libbluray: add optional fontconfig dependency Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150929194154.5377bd2a@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox