From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] board: add support for Synopsys VDK Software Development Platform
Date: Wed, 30 Sep 2015 12:34:26 +0200 [thread overview]
Message-ID: <20150930123426.5eb66486@free-electrons.com> (raw)
In-Reply-To: <3d88a36124c3fa652b6a54e3a2d0ac1e2c165375.1443605861.git.jpinto@synopsys.com>
Dear Joao Pinto,
On Wed, 30 Sep 2015 10:44:29 +0100, Joao Pinto wrote:
> The Virtualizer Development Kit (VDK) Family for ARM Cortex Products consists of a set of virtual
> prototypes that provide a virtualizer for the ARM core variants. The VDK is a standalone package that runs
> on an host computer.
You already sent the same patch yesterday. What are the changes in this
new version? New versions of patches should have a different version
number, and carry a changelog (see the Buildroot manual for details).
Also, your commit log message should be wrapped to ~72 characters.
> board/synopsys/vdk/fs-overlay/etc/inittab | 28 +
You could add a paragraph in your commit log that explains why a custom
inittab is used.
> board/synopsys/vdk/linux-vdk-defconfig | 2914 +++++++++++++++++++++++++++++
Please use a defconfig, which you can generate with "make
linux-update-defconfig". It will make the file much much smaller.
> diff --git a/configs/snps_vdk_defconfig b/configs/snps_vdk_defconfig
> new file mode 100644
> index 0000000..c1b1b8a
> --- /dev/null
> +++ b/configs/snps_vdk_defconfig
> @@ -0,0 +1,17 @@
> +BR2_aarch64=y
> +BR2_KERNEL_HEADERS_3_18=y
> +BR2_TARGET_GENERIC_HOSTNAME="vdk-buildroot"
> +BR2_TARGET_GENERIC_ISSUE="Welcome to SNPS VDK by Buildroot"
> +BR2_INIT_SYSV=y
No, please use the default init system (i.e Busybox).
> +BR2_SYSTEM_BIN_SH_BASH=y
Ditto, use the default value.
> +BR2_ROOTFS_OVERLAY="board/synopsys/vdk/fs-overlay"
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_GIT=y
> +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://git.linaro.org/kernel/linux-linaro-tracking.git"
> +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="linux-linaro-3.18-2014.12"
> +BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
> +BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/synopsys/vdk/linux-vdk-defconfig"
> +BR2_LINUX_KERNEL_IMAGE_TARGET_CUSTOM=y
> +BR2_LINUX_KERNEL_IMAGE_TARGET_NAME="Image"
> +BR2_PACKAGE_PCIUTILS=y
No special packages in defconfigs.
> +BR2_TARGET_ROOTFS_EXT2=y
Any reason to generate an ext2 filesystem here? Is it used for the
emulator/simulator?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-09-30 10:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 9:44 [Buildroot] board: add support for Synopsys VDK Software Development Platform Joao Pinto
2015-09-30 10:34 ` Thomas Petazzoni [this message]
2015-09-30 10:36 ` Joao Pinto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930123426.5eb66486@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox