From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/4] Remove trailing slash from all package site URLs
Date: Wed, 30 Sep 2015 12:47:07 +0200 [thread overview]
Message-ID: <20150930124707.3520a87e@free-electrons.com> (raw)
In-Reply-To: <1443456634-21484-2-git-send-email-luca@lucaceresoli.net>
Dear Luca Ceresoli,
On Mon, 28 Sep 2015 18:10:31 +0200, Luca Ceresoli wrote:
> The recommended form is without the trailing slash, and will become
> mandatory in a coming commit.
>
> This avoids the need for the $$($(2)_SITE:/=) magic in package/pkg-generic.mk
> to avoid double slashes in download URLs, like
> "https://mosh.mit.edu//mosh-1.2.5.tar.gz".
> ^^
>
> Note: this work has already been done in b0b9606530dfc6de4030 a few
> months ago and earlier in c7f4b964718bc5a3329b and 4a9eb20de817fa64,
> but no check has been added at that time to avoid new slashes to slip
> in, and so they did. This time a patch will follow immediately to
> prevent future mistakes from being unnoticed.
>
> Mass-replaced with the following command:
>
> git grep -l '_SITE.*/$' | xargs sed -i '/_SITE.*=/s|/$||'
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
>
> ---
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-09-30 10:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 16:10 [Buildroot] [PATCH v3 0/4] Cleanup trailing slashed from FOO_SITE Luca Ceresoli
2015-09-28 16:10 ` [Buildroot] [PATCH v3 1/4] Remove trailing slash from all package site URLs Luca Ceresoli
2015-09-30 10:47 ` Thomas Petazzoni [this message]
2015-09-28 16:10 ` [Buildroot] [PATCH v3 2/4] pkg-generic: prevent _SITE URLs with a trailing slash Luca Ceresoli
2015-09-28 17:27 ` Baruch Siach
2015-09-28 19:00 ` Luca Ceresoli
2015-09-30 10:45 ` Thomas Petazzoni
2015-10-03 12:01 ` Arnout Vandecappelle
2015-10-03 14:01 ` Arnout Vandecappelle
2015-10-03 15:07 ` Luca Ceresoli
2015-10-03 15:14 ` Arnout Vandecappelle
2015-09-28 16:10 ` [Buildroot] [PATCH v3 3/4] docs/manual: FOO_SITE must not have " Luca Ceresoli
2015-10-02 20:13 ` Thomas Petazzoni
2015-09-28 16:10 ` [Buildroot] [PATCH v3 4/4] download: get rid of trailing slash removal hack for FOO_SITE Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930124707.3520a87e@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox