Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libssh: bump to version 0.7.2
Date: Thu, 1 Oct 2015 22:37:49 +0300	[thread overview]
Message-ID: <20151001193749.GC3337@tarshish> (raw)
In-Reply-To: <CAMQcK5LhGU92=TX+JK_uBVBFYNK9fJf5ZNFQRgQ3LV8vquqYOQ@mail.gmail.com>

Hi Ryan,

On Thu, Oct 01, 2015 at 02:29:44PM -0500, Ryan Barnett wrote:
> On Thu, Oct 1, 2015 at 1:30 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> > Also, require threads support. cmake detects threads support correctly, but
> > libssh build system uses this information incorrectly.
> >
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> >  package/libssh/Config.in   | 5 +++--
> >  package/libssh/libssh.hash | 6 +++---
> >  package/libssh/libssh.mk   | 4 ++--
> >  3 files changed, 8 insertions(+), 7 deletions(-)
> >
> > diff --git a/package/libssh/Config.in b/package/libssh/Config.in
> > index 30aabd621fb6..3357fb9e9252 100644
> > --- a/package/libssh/Config.in
> > +++ b/package/libssh/Config.in
> > @@ -2,6 +2,7 @@ config BR2_PACKAGE_LIBSSH
> >         bool "libssh"
> >         depends on BR2_USE_MMU # fork()
> >         depends on !BR2_STATIC_LIBS
> > +       depends on BR2_TOOLCHAIN_HAS_THREADS
> >         # Either OpenSSL or libgcrypt are mandatory
> >         select BR2_PACKAGE_LIBGCRYPT if !BR2_PACKAGE_OPENSSL
> >         help
> > @@ -12,6 +13,6 @@ config BR2_PACKAGE_LIBSSH
> >
> >           http://www.libssh.org/
> >
> > -comment "libssh needs a toolchain w/ dynamic library"
> > +comment "libssh needs a toolchain w/ dynamic library, threads"
> >         depends on BR2_USE_MMU
> > -       depends on BR2_STATIC_LIBS
> > +       depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
> 
> It appears that this patch an your previous patch should be a series.
> Was this your intention?
> 
> This patch assume that your previous patch has been applied in order
> to bump the version. Your previous patch being "libssh: needs shared
> library support" [1].
> 
> [1] - http://lists.busybox.net/pipermail/buildroot/2015-October/140551.html

Correct. Only after sending the first patch I figured out that there is a new 
libssh release.

Thanks for noticing,
baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2015-10-01 19:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-01 18:30 [Buildroot] [PATCH] libssh: bump to version 0.7.2 Baruch Siach
2015-10-01 19:29 ` Ryan Barnett
2015-10-01 19:37   ` Baruch Siach [this message]
2015-10-02 14:42 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151001193749.GC3337@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox